Add parser/dresser for naked COSE keys #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geonnave
reviewed
Feb 3, 2025
shared/src/cred.rs
Outdated
| @@ -359,6 +312,103 @@ impl Credential { | |||
| } | |||
| } | |||
|
|
|||
| /// Parse a COSE Key, accepting only understood fields. | |||
| /// | |||
| /// This takes a decoder rather than a slice because this enables a naked decoder to asset that | |||
|
Looks good to me, left just a minor comment, then I am ready to merge. |
This allows processing some generally valid cases that could not be processed before, eg. CCSs without a KID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #336, and refactors the
parse_ccs()function, broadening the range of accepted items.Closes: #336