beep: Fix dependency for platforms other than x86 #25458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a platform other than x86 is selected, the kmod-gpio-beeper module is automatically selected. The previous setting did not choose it automatically, preventing loading in different modules.
|
There is missing Signed-off-by in your commit. Would you mind to add it? |
I will prepare new PR with all requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @paulfertser
Compile tested: x86_64, ARMv8_64b; OpenWRT 22.03, OpenWRT Master
Run tested: x86_64, ARMv8_64b; OpenWRT 22.03, OpenWRT Master
Description:
If a platform other than x86 is selected, the kmod-gpio-beeper module is automatically selected. The previous setting did not choose it automatically. The previous dependency makes module recursion problems.
Signed-off-by: Zbyněk Kocur [email protected]