Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: Update to 1.23.1 #24992

Merged
merged 3 commits into from
Oct 1, 2024
Merged

golang: Update to 1.23.1 #24992

merged 3 commits into from
Oct 1, 2024

Conversation

p-w-p
Copy link
Contributor

@p-w-p p-w-p commented Sep 18, 2024

Maintainer: @jefferyto
Compile tested: all supported targets
Run tested: rockchip/armv8

Description:
The latest Go release, version 1.23, arrives six months after Go 1.22. Most of its changes are in the implementation of the toolchain, runtime, and libraries. As always, the release maintains the Go 1 promise of compatibility. We expect almost all Go programs to continue to compile and run as before.

@p-w-p
Copy link
Contributor Author

p-w-p commented Sep 18, 2024

CC @1715173329 @mochaaP

@p-w-p p-w-p force-pushed the patch-1 branch 2 times, most recently from d2503ab to aec400e Compare September 18, 2024 13:18
@p-w-p p-w-p marked this pull request as draft September 18, 2024 14:17
@BKPepe
Copy link
Member

BKPepe commented Sep 18, 2024

At least from my side, it was better as it was done in the previous PR.
1st commit update to 1.23.0 with adding more values
and then the 2nd commit with the other update.

Doing this in one commit could be messy.

@p-w-p p-w-p force-pushed the patch-1 branch 2 times, most recently from 354983d to 3ed26eb Compare September 28, 2024 07:20
@1715173329
Copy link
Member

Please update GOROOT_FINAL according to #24802 (comment).

@p-w-p p-w-p force-pushed the patch-1 branch 2 times, most recently from 3575e8e to 1b4d836 Compare September 28, 2024 08:03
@1715173329 1715173329 marked this pull request as draft September 29, 2024 14:34
@1715173329
Copy link
Member

According to golang/go#62047, GOROOT_FINAL should be fine to remove from Makefile directly.

@p-w-p p-w-p force-pushed the patch-1 branch 3 times, most recently from e7f1f4b to 33935b6 Compare September 29, 2024 15:54
@p-w-p p-w-p marked this pull request as ready for review September 29, 2024 16:39
Go 1.23.1 (released 2024-09-05) includes security fixes to
the encoding/gob, go/build/constraint, and go/parser
packages. It also addresses bug fixes in the compiler,
go command, runtime, and the database/sql, go/types,
os, runtime/trace, and unique packages.

Signed-off-by: Milinda Brantini <[email protected]>
@1715173329
Copy link
Member

Thinking it's time to give it a shot, any idea?

p-w-p and others added 2 commits October 1, 2024 17:59
Added GOARM64 and GORISCV64 in golang-build.sh.
Drop deprecated GOROOT_FINAL in GoCompiler/Default/Make.
Updated environment vars in golang-values.mk for GOARM64 and GORISCV64.
Refined host build in golang/Makefile for openbsd_riscv64.

Co-authored-by: Tianling Shen <[email protected]>
Signed-off-by: Milinda Brantini <[email protected]>
Co-authored-by: Tianling Shen <[email protected]>
Signed-off-by: Milinda Brantini <[email protected]>
@1715173329 1715173329 merged commit 88a01c4 into openwrt:master Oct 1, 2024
12 of 13 checks passed
@p-w-p p-w-p deleted the patch-1 branch October 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants