miniupnpd: Revise several upnpd UCI configuration options and defaults
#24988
+165
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-Hosting-Group
force-pushed
the
miniupnpd-uci-revision
branch
2 times, most recently
from
ac76334
to
618ed1f
Compare
added 8 commits
October 1, 2024 00:00
as not working Signed-off-by: Self Hosting Group <[email protected]>
`enable_pcp_pmp` as upstream, see miniupnp/miniupnp@02da705 Signed-off-by: Self Hosting Group <[email protected]>
`secure_mode` UCI config option is disabled Signed-off-by: Self Hosting Group <[email protected]>
to kbit/s and rename to `*_kbps`, and update defaults to 100/50 Mbit/s (informational only) Signed-off-by: Self Hosting Group <[email protected]>
UCI config option accepts `igdv1`/`igdv2`, replacing the current `igdv1` boolean option, allowing future compatibility modes Signed-off-by: Self Hosting Group <[email protected]>
`allow_third_party_maps` Signed-off-by: Self Hosting Group <[email protected]>
and add (template) ACL entry for low ports (<1024) denied by default, current behaviour Signed-off-by: Self Hosting Group <[email protected]>
Signed-off-by: Self Hosting Group <[email protected]>
Self-Hosting-Group
force-pushed
the
miniupnpd-uci-revision
branch
from
618ed1f
to
6da251a
Compare
|
@Self-Hosting-Group: Nice PR! cc: @systemcrash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean_ruleset_interval/thresholdUCI config options as not workingenable_nat_pmptoenable_pcp_pmpas upstream, see miniupnp/miniupnp@02da705secure_modeUCI config option is disabledsecure_modeUCI config also for UPnP IGD with IPv6, previously it was always enabled and the behaviour is undocumented. See miniupnp/miniupnp@c79e25adownload/uploadUCI config option from KByte/s to kbit/s and rename to*_kbps, and update defaults to 100/50 Mbit/s (informational only)upnp_igd_compatUCI config option acceptsigdv1/igdv2, replacing the currentigdv1boolean option, allowing future compatibility modessecure_modetoallow_third_party_mapsupnpdUCI config file and add (template) ACL entry for low ports (<1024) denied by default, current behaviourMaintainer:
Compile tested: not on OpenWrt as one-line daemon patch but compiled/tested outside of project
Run tested: daemon init/config generation and uci-defaults migration using OpenWrt snapshots