wfb-ng: Add wfb-ng package #24974

svpcom · 2024-09-15T09:44:09Z

Maintainer: me
Compile tested: (MIPS 74Kc, TP-Link CPE510, openwrt-23.05)
Run tested: (MIPS 74Kc, TP-Link CPE510, tests done)

Description:
WFB-ng is long-range packet radio link based on raw WiFi radio.

Adding it to openwrt base packages will help a lot of it users to use cheap wifi routers (supporting minitoring mode) instead of build custom hardware yourself.

net/wfb-ng/Makefile

zpc0 · 2024-09-15T12:36:03Z

It seems PKG_MIRROR_HASH is missing.

svpcom · 2024-09-15T19:09:58Z

It seems PKG_MIRROR_HASH is missing.

I use direct git commit id as source so PKG_MIRROR_HASH is not needed

svpcom · 2024-09-15T21:58:12Z

@zpc0 I've fixed formal commit description, added Signed-by and PKG_MIRROR_HASH. Could you restart automatic workflow build?

BKPepe

While looking at the readme in the repository, II see that there are only two supported WiFi chips and both requires external patched driver. I am not use, if this makes any sense for us since it requires so much work and it does not work out of the box unless you are using patched drivers.

BKPepe · 2024-09-15T22:28:07Z

net/wfb-ng/Makefile

+include $(TOPDIR)/rules.mk
+
+PKG_NAME:=wfb-ng
+PKG_VERSION:=24.9.1


This version is not released nor tagged.

https://github.com/svpcom/wfb-ng/tree/wfb-ng-24.09-openwrt-preview
I've added tag for it

I have a lot of requests from wfb-ng users that want to try wfb-ng on their wifi routers but for most of them compiling external packets is too hard that is why I've done this pull-request

BKPepe · 2024-09-15T22:28:27Z

net/wfb-ng/Makefile

+PKG_SOURCE_PROTO:=git
+PKG_SOURCE_URL:=https://github.com/svpcom/wfb-ng.git
+PKG_SOURCE_VERSION:=a41cd378e7e23dd094d6c50f26c4faa8e64e5954
+PKG_MIRROR_HASH:=362b3d4262e78ae0885cc25cea34e553dc29e1941be47724ece796bd35220d88


Why do we need to clone Git sources? We can use tarball. :-)

IMHO for review (or for compare changes between two different versions) direct link to git commit is more preferable than tarball

Comparing changes between two differents versions, thats why the tagged releases or tags are for. Still, I dont see reason, why BFU or the end user should care about your commit hashes, they want to have version and of course. Having double versioning in the Makefile, its odd even for developers. The version, which is not tagged, then it checkout sources and specific commit, no, no. Thats wrong.

Choose properly which one and I think you want to use tagged releases. :-)

@BKPepe Ok. I've replaced it with PKG_SOURCE_VERSION:=wfb-ng-24.09-openwrt-preview now

net/wfb-ng/Makefile

svpcom · 2024-09-15T22:49:22Z

@BKPepe In ath9k SoC (for example TP-Link CPE510) injection works out of box with standard driver. Also most of the cards supports monitoring mode and wfb-ng can work in RX-only mode with them

While looking at the readme in the repository, II see that there are only two supported WiFi chips and both requires external patched driver. I am not use, if this makes any sense for us since it requires so much work and it does not work out of the box unless you are using patched drivers.

snokvist · 2024-09-16T20:46:05Z

Hello, me and @zhouruixi (well mostly zhou) have verified several routers for wfb_ng and we are using it succesfully on them to operate drone video feeds. Like svpcom says, injection is only needed for bidirectional links, and for many drone operators(including me) unidirectional is enough. We already have 10 tested and verified working routers: https://github.com/OpenIPC/wfb-ng-openwrt/wiki/0.-Tested-devices

It would be great for more routers to have injection, but for example having one cpe510 added to the mix is enough (i use two google wifi and one asus, soon one cpe510 to boost extra range). I have several kilometers range using this setup.

Having wfb_ng easily available instead of building manually could revolutionize how OpenIPC can be used in the future, powered by OpenWRT+wfb_ng.

Already runcam and EMAX is selling openipc hardware with users looking for a good transmission link layer setup.

Zhou is spreading this also in his Chinese community and there will be many more users if we can simplify installation!

libc0607 · 2024-09-17T18:06:56Z

It will be great if OpenWrt has the wfb-ng package.

Almost all those IP Camera chips have old (~4.9) kernels and seems nobody gonna backport the new Wi-Fi drivers -- that's why only the RTL8812xU series adapters, with an out-of-kernel driver, were often heard in FPV scenarios.

It will be easier for pilots to test monitor & packet injection on different adaptors supported by the mainline kernel if OpenWrt has the wfb-ng package.

BTW, the ath9k injection works really well (on OpenWrt) :)

WFB-ng is long-range packet radio link based on raw WiFi radio. Adding it to openwrt base packages will help a lot of it users to use cheap wifi routers (supporting minitoring mode) instead of build custom hardware yourself. Signed-off-by: Vasily Evseenko <[email protected]>

net/wfb-ng/Makefile

Co-authored-by: Tianling Shen <[email protected]> Signed-off-by: Vasily Evseenko <[email protected]>

net/wfb-ng/Makefile

BKPepe · 2024-09-23T08:15:41Z

net/wfb-ng/files/wfb-ng.init

+SYSUPGRADE_CONF="/etc/sysupgrade.conf"
+WFB_INIT="/usr/sbin/wfb-ng.sh"
+
+if [ -f $SYSUPGRADE_CONF ] && [ -x $WFB_INIT ] && ! grep -q $WFB_INIT $SYSUPGRADE_CONF
+then
+   echo $WFB_INIT >> $SYSUPGRADE_CONF
+fi


I am not sure, what you would like to achieve with this one? You want to persist init file through sysupgrade? Do you know how the sysupgrade works?

/usr/sbin/wfb-ng.sh is a custom init script, generated by user. I want to persist it during sysupgrade

Definitely, this should not be here. Usually there is section conffiles, but in that case, the file is mentioned in the Makefile.

How to add /usr/sbin/wfb-ng.sh to /etc/sysupgrade.conf in the Makefile? I've tried to search this in other openwrt packages, but found only the way above in net/p910nd/files/p910nd.hotplug

define a conffiles recipe.

FYI:

packages/net/alist/Makefile

Lines 47 to 50 in 99c28c2

define Package/alist/conffiles

/etc/alist/

/etc/config/alist

endef

@1715173329 fixed. Thanks!

The question is if this is going to work, though. Needs to be tested for files, which are not included/presented in the Makefile.

@BKPepe Alredy done. Package was built successfully

Also i've checked it on real hardware (TP-Link CPE510v3).

net/wfb-ng/files/wfb-ng.init

Signed-off-by: Vasily Evseenko <[email protected]>

cinoan · 2024-10-16T14:22:57Z

I hope this can move forward, I've been using wfb-ng (and it's predecessors) for some years and the prospect of using it on OpenWrt for a distributed receive network is really exciting. I've just purchased a couple of cpe510s as test nodes but am now learning how tricky it is to build compared to installing a package.

Thank you to those working on this.

svpcom · 2024-10-16T15:08:49Z

How to fix error during CI build? Locally it builds without problems.

stangri · 2024-10-17T00:51:55Z

net/wfb-ng/Makefile

+include $(INCLUDE_DIR)/package.mk
+
+MAKE_FLAGS += VERSION=$(PKG_VERSION)-$(PKG_RELEASE) COMMIT=openwrt all_bin
+PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_NAME)-$(PKG_VERSION)


I'm guessing this is what results in /builder/build_dir/target-aarch64_generic_musl/wfb-ng-wfb-ng-24.09.23/ and then some tasks at the end of the build process failing? Have you tried PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION)

@stangri Yes. This is done due to github auto packaging issue. It automatically create archive for release with following structure:

$ tar tzvf wfb-ng-24.08.2.tar.gz | head drwxrwxr-x root/root 0 2024-10-01 16:49 wfb-ng-wfb-ng-24.08.2/ drwxrwxr-x root/root 0 2024-10-01 16:49 wfb-ng-wfb-ng-24.08.2/.github/ drwxrwxr-x root/root 0 2024-10-01 16:49 wfb-ng-wfb-ng-24.08.2/.github/ISSUE_TEMPLATE/ ...

It concatenate project name + tag name (which is wfb-ng-24.08.2 in this case)

I see. I thought there was a way to override this from the Makefile as I've had to deal with a similarly weirdly named archive content before, but maybe I'm misremembering things.

Hello, any updates on this package? The OpenIPC fpv project is getting increasing interest and many requests when the package will be ready for easy deployment. I have 4 different router models up and running myself with the latest makefile, but it's a ... shitparty ... to compile manually from sources :)

zpc0 reviewed Sep 15, 2024

View reviewed changes

net/wfb-ng/Makefile Outdated Show resolved Hide resolved

zpc0 reviewed Sep 15, 2024

View reviewed changes

net/wfb-ng/Makefile Outdated Show resolved Hide resolved

svpcom force-pushed the master branch from ffd1763 to d9f03de Compare September 15, 2024 21:55

BKPepe requested changes Sep 15, 2024

View reviewed changes

svpcom requested review from BKPepe and zpc0 September 15, 2024 23:04

svpcom force-pushed the master branch from 3e5cbe0 to de9bb23 Compare September 17, 2024 14:56

svpcom force-pushed the master branch from de9bb23 to 6fc3e26 Compare September 20, 2024 15:02

svpcom force-pushed the master branch from 6fc3e26 to f815f92 Compare September 20, 2024 15:53

1715173329 requested changes Sep 21, 2024

View reviewed changes

net/wfb-ng/Makefile Show resolved Hide resolved

net/wfb-ng/Makefile Outdated Show resolved Hide resolved

net/wfb-ng/Makefile Outdated Show resolved Hide resolved

net/wfb-ng/Makefile Outdated Show resolved Hide resolved

svpcom force-pushed the master branch from e7e76c0 to 681686b Compare September 21, 2024 12:20

wfb-ng: Update net/wfb-ng/Makefile

235dde0

Co-authored-by: Tianling Shen <[email protected]> Signed-off-by: Vasily Evseenko <[email protected]>

svpcom force-pushed the master branch from 681686b to 235dde0 Compare September 21, 2024 12:30

BKPepe requested changes Sep 23, 2024

View reviewed changes

svpcom added 3 commits September 23, 2024 13:07

wfb-ng: remove NAME from wfb-ng.init

78a171a

Signed-off-by: Vasily Evseenko <[email protected]>

wfb-ng: fix sysupgrade usage

3c16ec2

Signed-off-by: Vasily Evseenko <[email protected]>

wfb-ng: use release tgz instead of git

620f3e7

Signed-off-by: Vasily Evseenko <[email protected]>

svpcom requested review from BKPepe and 1715173329 September 27, 2024 21:51

stangri reviewed Oct 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wfb-ng: Add wfb-ng package #24974

wfb-ng: Add wfb-ng package #24974

svpcom commented Sep 15, 2024 •

edited

Loading

zpc0 commented Sep 15, 2024

svpcom commented Sep 15, 2024

svpcom commented Sep 15, 2024

BKPepe left a comment

BKPepe Sep 15, 2024

svpcom Sep 15, 2024

svpcom Sep 15, 2024

BKPepe Sep 15, 2024

svpcom Sep 15, 2024

BKPepe Sep 20, 2024

svpcom Sep 20, 2024

svpcom commented Sep 15, 2024

snokvist commented Sep 16, 2024 •

edited

Loading

libc0607 commented Sep 17, 2024

BKPepe Sep 23, 2024

svpcom Sep 23, 2024

BKPepe Sep 23, 2024

svpcom Sep 23, 2024

1715173329 Sep 23, 2024

svpcom Sep 23, 2024

BKPepe Sep 23, 2024

svpcom Sep 23, 2024 •

edited

Loading

svpcom Sep 23, 2024 •

edited

Loading

cinoan commented Oct 16, 2024

svpcom commented Oct 16, 2024

stangri Oct 17, 2024

svpcom Oct 17, 2024

stangri Oct 17, 2024

snokvist Oct 23, 2024

	define Package/alist/conffiles
	/etc/alist/
	/etc/config/alist
	endef

wfb-ng: Add wfb-ng package #24974

Are you sure you want to change the base?

wfb-ng: Add wfb-ng package #24974

Conversation

svpcom commented Sep 15, 2024 • edited Loading

zpc0 commented Sep 15, 2024

svpcom commented Sep 15, 2024

svpcom commented Sep 15, 2024

BKPepe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

svpcom commented Sep 15, 2024

snokvist commented Sep 16, 2024 • edited Loading

libc0607 commented Sep 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

svpcom Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

svpcom Sep 23, 2024 • edited Loading

Choose a reason for hiding this comment

cinoan commented Oct 16, 2024

svpcom commented Oct 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

svpcom commented Sep 15, 2024 •

edited

Loading

snokvist commented Sep 16, 2024 •

edited

Loading

svpcom Sep 23, 2024 •

edited

Loading

svpcom Sep 23, 2024 •

edited

Loading