-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/206 #207
Feature/206 #207
Conversation
Fix connectivity issue
Add new name convention Move connectivity to ui
geppetto-ui/src/components/big-image-viewer/showcase/BigImageViewerConfig.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @afonsobspinto, added a few minor comments
Hello @filippomc, I think I addressed all of the minor comments you have added. Please let me know if you want anything else to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @afonsobspinto, this is great stuff.
Closes #195 #197 #202 #206
Contains:
Some notes already discussed but will not be on this PR (unless said otherwise):
Originally posted by @filippomc in #198:
Those
geppetto-client/geppetto-client
scare me. If someone looks at it without knowing the history easily thinks thinks it's a bad copy/paste to fix. Also we should remove direct references to files being inside node_modules. If we don't do that, we need to include the node_modules folder in every deployment. @tarelli I think that getting rid of those references may be one of the next refactorings.