Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/206 #207

Merged
merged 27 commits into from
Apr 16, 2020
Merged

Feature/206 #207

merged 27 commits into from
Apr 16, 2020

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Mar 31, 2020

Closes #195 #197 #202 #206
Contains:

  • The geppetto structural split (client, ui, showcase)
  • Showcase for BigImageViewer and Connectivity components, following the enhanced showcase template. See lunpark-dev#Geppetto-Showcase for additional information.
  • Basic showcase for Plot, FlexLayout, MoviePlayer, GraphVisualizer, ListViewer and Menu (all should be 'easily' updatable to the new structure).

Some notes already discussed but will not be on this PR (unless said otherwise):

  • Change plot component to use only instances instead of full model
  • Python console, show an image (for now)
  • Improve showcase UI/UX ( add material paper, add button to copy source code, others...)
  • Add toolbar common component
  • Do not set the height -> use flex instead

Originally posted by @filippomc in #198:
Those geppetto-client/geppetto-client scare me. If someone looks at it without knowing the history easily thinks thinks it's a bad copy/paste to fix. Also we should remove direct references to files being inside node_modules. If we don't do that, we need to include the node_modules folder in every deployment. @tarelli I think that getting rid of those references may be one of the next refactorings.

@afonsobspinto afonsobspinto added the enhancement New feature or request label Mar 31, 2020
@afonsobspinto afonsobspinto requested a review from filippomc April 2, 2020 10:23
This was referenced Apr 2, 2020
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afonsobspinto, added a few minor comments

@afonsobspinto
Copy link
Member Author

Hello @filippomc, I think I addressed all of the minor comments you have added. Please let me know if you want anything else to be changed.

@afonsobspinto afonsobspinto requested a review from filippomc April 15, 2020 17:39
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afonsobspinto, this is great stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants