[test] Added some tests for basic functions

basic_functions.lua

@@ -1,5 +1,8 @@
+local inspect = require('inspect')
+
+basic_functions = {}
 -- split function
-function split(str, pat)
+function basic_functions.split(str, pat)
     local t = {}
     local fpat = "(.-)" .. pat
     local last_end = 1
@@ -18,7 +21,7 @@ function split(str, pat)
     return t
 end
 
-function has_value(tab, val)
+function basic_functions.has_value(tab, val)
     for index, value in ipairs(tab) do
         if value == val then
             return true
@@ -27,22 +30,24 @@ function has_value(tab, val)
     return false
 end
 
-function starts_with(str, start)
+function basic_functions.starts_with(str, start)
     return str:sub(1, #start) == start
 end
 
-function is_table_empty(table_)
+function basic_functions.is_table_empty(table_)
     return not table_ or next(table_) == nil
 end
 
-function array_concat(source, destination)
+function basic_functions.array_concat(source, destination)
     table.foreach(source, function(key, value)
         table.insert(destination, value)
     end)
 end
 
-function dict_merge(source, destination)
+function basic_functions.dict_merge(source, destination)
     table.foreach(source, function(key, value)
         destination[key] = value
     end)
 end
+
+return basic_functions

netjson-monitoring.lua

@@ -348,7 +348,7 @@ function get_interface_info(name, netjson_interface)
 end
 
 -- collect interface addresses
-function get_addresses(name)
+function try.get_addresses(name)
     addresses = {}
     interface_list = interface_data['interface']
     addresses_list = {}

tests/test_basic_functions.lua

@@ -0,0 +1,31 @@
+local lu = require('luaunit')
+
+local basic_functions = require('basic_functions')
+
+function testSplitFunction()
+	-- When pattern is present
+	lu.assertEquals(basic_functions.split("OpenWISP","n"), {"Ope", "WISP"})
+	lu.assertEquals(basic_functions.split("OpenWISP","WISP"), {"Open"})
+
+	-- When pattern is not available
+	lu.assertEquals(basic_functions.split("OpenWISP","a"), {"OpenWISP"})
+end
+
+function testHasValue()
+	-- When value is present
+	lu.assertEquals(basic_functions.has_value({2,4,5},4), true)
+	lu.assertEquals(basic_functions.has_value({1,2,3,7,9},9), true)
+
+	-- When value is not present
+	lu.assertEquals(basic_functions.has_value({2,4,5},3), false)
+	lu.assertEquals(basic_functions.has_value({1,2,3,7,9},8), false)
+
+end
+
+function testRandom()
+	-- When value is present
+	-- lu.assertEquals(netjson_monitoring.)
+
+end
+
+os.exit( lu.LuaUnit.run() )

tests/test_netjson_monitoring.lua

@@ -31,18 +31,13 @@ sample_ip_neigh = {
 
 
 function testArpTable()
+
 	lu.assertEquals(neighbor.parse_arp(), sample_parse_arp)
-end
 
-function testIpNeighJson()
 	lu.assertEquals(neighbor.get_ip_neigh_json(), sample_ip_neigh)
-end
 
-function testIpNeigh()
 	lu.assertEquals(neighbor.get_ip_neigh(), sample_ip_neigh)
-end
 
-function testgetNeighbor()
 	lu.assertEquals(neighbor.get_neighbors(), sample_ip_neigh)
 end