-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] Bump nginx from 1.23.4-alpine to 1.27.0-alpine in /images/openwisp_nginx #318
[deps] Bump nginx from 1.23.4-alpine to 1.27.0-alpine in /images/openwisp_nginx #318
Conversation
b19bf4c
to
8a8c3ef
Compare
8a8c3ef
to
14b03bf
Compare
@dependabot rebase |
14b03bf
to
c1d72d4
Compare
c1d72d4
to
4f18d26
Compare
|
||
RUN apk add --update --no-cache \ | ||
openssl~=3.0.15-r0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openssl is included in the base image.
images/openwisp_nginx/Dockerfile
Outdated
py3-pip \ | ||
certbot \ | ||
certbot-nginx && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the version specifiers from the system packages because there's only one version available to download from the Alpine repositories. Pinning dependencies leads to failing builds all the time with little to no benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have to choose between the risk of a new incompatible version being released and them yanking an insecure release
I think we shouldn't start changing things now and leave it in an inconsistent state, I think is better to keep pinning now
if we want to change it, we should create an issue, plan it and execute it
not have some stuff unpinned and some pinned
it just makes everything more confusing
4f18d26
to
4c3192b
Compare
Bumps nginx from 1.23.4-alpine to 1.27.0-alpine. --- updated-dependencies: - dependency-name: nginx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
4c28f4c
to
a6c4be9
Compare
Bumps nginx from 1.23.4-alpine to 1.27.0-alpine.
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)