Recover syntax highlighting for sample problems. #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
approved these changes
Nov 29, 2024
drgrice1
force-pushed
the
pg-codemirror-static
branch
2 times, most recently
from
fe91836 to
10fc144
Compare
drgrice1
force-pushed
the
pg-codemirror-static
branch
2 times, most recently
from
c50576a to
2b9446a
Compare
|
Note that the version of the (I accidentally put this comment in openwebwork/pg#1149, but it was meant for this pull request.) |
This was an oversight when I made the switch to the PG CodeMirror editor with CodeMirror 6. The sample problems also use CodeMirror for syntax highlighting. Since the CodeMirror 5 javascript is no longer available that fails. The pg-codemirror-editor package now exports a `runMode` method (available via the global `PGCodeMirrorEditor` object), that essentially does what the CodeMirror 5 `runMode` addon method did. It is slightly different in that it only works for the PG language. At this point we don't use it for anything else, so that should be good for now.
drgrice1
force-pushed
the
pg-codemirror-static
branch
from
2b9446a to
3c73acc
Compare
somiaj
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight when I made the switch to the PG CodeMirror editor with CodeMirror 6. The sample problems also use CodeMirror for syntax highlighting. Since the CodeMirror 5 javascript is no longer available that fails.
The pg-codemirror-editor package now exports a
runModemethod (available via the globalPGCodeMirrorEditorobject), that essentially does what the CodeMirror 5runModeaddon method did. It is slightly different in that it only works for the PG language. At this point we don't use it for anything else, so that should be good for now.