-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tailor AsciiMath better for MathObjects #2296
Conversation
30d6eea
to
28fa07a
Compare
I made some changes to this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me for the most part.
This file needs some work though.
It needs to be updated to use modern javascript. The var
usage needs to be updated to const
or let
appropriately. I have done this, and was going to make a pull request at some point. Note that you have two var i
definitions (on lines 11 and 38). Those are actually the same variable as the second gets hoisted. That is why var
should never be used anymore. The for
loop does not limit scope of a var
.
Also, the formatting will need to be cleaned up. Soon I plan to add a workflow to use prettier
on javascript files for formatting. The newTriggers
definition will be expanded quite a bit since it exceeds the 120 character limit.
I updated the var declarations I added (but not the ones that were already in the file and not part of this change). I'm not sure how best to change the formatting on |
Don't worry about the prettier formatting. That will be taken care of when it is ready. I just wanted to point out that the wide formatting wont work with that. Like perltidy, prettier will auto format the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Should we close #638 now? |
This makes changes to the AsciiMath portion of the MathJax config so that it behaves more consistently with MathObjects. AsciiMath input is used by MathView and can be used when composing text that can have math that will be rendered (a student's essay answer or instructor feedback). Changes are:
in
, so you don't see a∈
on your way to making∞
.ne
so you can enterdne
andnone
without seeingd≠
andno≠
.**
be interpreted as^
.infty
withinf
.Re
,Im
,log10
,U
, and><
.This is well on its way to addressing #638. Perhaps more can be done to get greater consistency with MathObjects and AsciiMath input, but the process is demonstrated now for removing, modifying, or adding triggers.