Make SQL::Abstract work. #2276
Merged
Make SQL::Abstract work. #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
sql-abstract
branch
from
f6bd38c to
b73ea3b
Compare
drgrice1
force-pushed
the
sql-abstract
branch
2 times, most recently
from
db3871a to
6992f9a
Compare
drgrice1
force-pushed
the
sql-abstract
branch
4 times, most recently
from
f746f89 to
e078337
Compare
This removes the optional dependence on SQL::Abstract::Classic or a version of SQL::Abstract prior to 2.000000, and only uses version 2.000000 or newer of SQL::Abstract. For this to work the capability of a field override needs to be removed. There doesn't seem to be a reliable way to do that with the newer versions of SQL::Abstract, although I didn't try very hard. I also don't see the need for having a field override. The only field that has an override is the `key_not_a_keyfield` or `key` field. Why was that ever done? Did someone think that MySQL would make a field a database key field if it had the name "key"? Did someone think it would be confusing to have a field named "key" that was not a database key field? It was probably the latter, but in my opinion the field override was even more confusing. The `key` field in the `key` table does not contain any permanent data, so upgrading courses does not require any special handling. The data from the old `key_not_a_keyfield` field can be safely dropped, and the new `key` field used in its place. You can leave the `key_not_a_keyfield` field in the database if you want to switch back and forth between other pull requests that use the `key_not_a_keyfield` field.
drgrice1
force-pushed
the
sql-abstract
branch
from
e078337 to
a81f77f
Compare
drdrew42
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the optional dependence on SQL::Abstract::Classic or a version of SQL::Abstract prior to 2.000000, and only uses version 2.000000 or newer of SQL::Abstract.
For this to work the capability of a field override needs to be removed. There doesn't seem to be a reliable way to do that with the newer versions of SQL::Abstract, although I didn't try very hard. I also don't see the need for having a field override. The only field that has an override is the
key_not_a_keyfieldorkeyfield. Why was that ever done? Did someone think that MySQL would make a field a database key field if it had the name "key"? Did someone think it would be confusing to have a field named "key" that was not a database key field? It was probably the latter, but in my opinion the field override was even more confusing.The
keyfield in thekeytable does not contain any permanent data, so upgrading courses does not require any special handling. The data from the oldkey_not_a_keyfieldfield can be safely dropped, and the newkeyfield used in its place. You can leave thekey_not_a_keyfieldfield in the database if you want to switch back and forth between other pull requests that use thekey_not_a_keyfieldfield.