Skip to content

update several matrix methods to apply to degree n matrices #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025

Conversation

Alex-Jordan
Copy link
Contributor

This builds on #1215. If #1215 is updated following feedback, I will update here too. Once #1215 is merged, this diff should be more manageable.

In addition to changes from #1215, this has:

  • some more POD and code comments updated to reflect how methods can be applied to degree n matrices, as well as specify in some places where the method only applies for degree 2 matrices
  • make the following methods apply to degree n matrices: isUpperTriangular, isLowerTriangular, isDiagonal, isSymmetric, isOrthogonal, isREF, isRREF. For a degree 1 Matrix, it is interpreted as a 1xk degree 2 Matrix. For degree > 2, these features can apply to all of the degree 2 matrices in the frontal slice.

@Alex-Jordan Alex-Jordan changed the title Matrices 2 update several matrix methods to apply to degree n matrices Mar 24, 2025
Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this generally looks good. Again some minor code comments.

I tested this by adding some columns to the test problem you gave in #1215, and things are working as expected.

@Alex-Jordan Alex-Jordan force-pushed the matrices-2 branch 2 times, most recently from 8d038fc to eeee7a8 Compare March 29, 2025 05:52
Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@Alex-Jordan
Copy link
Contributor Author

If we merge this one I'll rebase #1217.

@drgrice1 drgrice1 merged commit e410541 into openwebwork:develop Apr 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants