-
-
Notifications
You must be signed in to change notification settings - Fork 77
update several matrix methods to apply to degree n matrices #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this generally looks good. Again some minor code comments.
I tested this by adding some columns to the test problem you gave in #1215, and things are working as expected.
8d038fc
to
eeee7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
If we merge this one I'll rebase #1217. |
This builds on #1215. If #1215 is updated following feedback, I will update here too. Once #1215 is merged, this diff should be more manageable.
In addition to changes from #1215, this has:
isUpperTriangular
,isLowerTriangular
,isDiagonal
,isSymmetric
,isOrthogonal
,isREF
,isRREF
. For a degree 1 Matrix, it is interpreted as a 1xk degree 2 Matrix. For degree > 2, these features can apply to all of the degree 2 matrices in the frontal slice.