fix: centralize the deactivation of elements under the tour modal for TalkBack #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alkBack Signed-off-by: ClaudeArs <[email protected]>
bryce-mcmath
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Diffs to this file should not be committed
| /> | ||
| {CustomNavStack1 ? <Stack.Screen name={Stacks.CustomNavStack1} component={CustomNavStack1} /> : null} | ||
| </Stack.Navigator> | ||
| <SafeAreaView |
There was a problem hiding this comment.
I think should just be a View, no? So that the individual screens can apply their own SafeAreaView configs. No bg color needed
fc-santos
changed the title
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
Signed-off-by: ClaudeArs <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Centralize the deactivation of elements under the modalTour for TalkBack. As a replacement for PR (fix: disable header elements and bottom nav for TalkBack during tours #1441)
Screenshots, videos, or gifs
N/A
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓