feat: enter pin for biometrics ui update #1422
Conversation
LippaC-OPS
force-pushed
the
feat/enter-pin-biometrics-ui-update
branch
2 times, most recently
from
f97ebe7 to
38225fe
Compare
|
Update so we can review PR. |
| @@ -57,19 +58,19 @@ const PINEnter: React.FC<PINEnterProps> = ({ setAuthenticated, usage = PINEntryU | |||
| const [inlineMessageField, setInlineMessageField] = useState<InlineMessageProps>() | |||
| const [inlineMessages] = useServices([TOKENS.INLINE_ERRORS]) | |||
| const [alertModalMessage, setAlertModalMessage] = useState('') | |||
| // Temporary until all use cases are built with the new design | |||
There was a problem hiding this comment.
What is meant by "all use cases" here?
There was a problem hiding this comment.
Still have this question. Do you mean all extensions of Bifold or all uses of the PINEnter screen? Is PINEntryUsage.PINCheck eventually going to be the same as PINEntryUsage.ChangeBiometrics?
There was a problem hiding this comment.
My understanding is that this screen for all the different use cases will have similar design changes I just didn't put them through all at once in this PR.
There was a problem hiding this comment.
oh ok so by use cases you mean the different PINEntryUsage types and the UX folks don't want to change the styles for all of them at once yet. I understand now, all good 👍
| @@ -1,10 +1,11 @@ | |||
| import React from 'react' | |||
| import { KeyboardAvoidingView, Platform, ScrollView } from 'react-native' | |||
| import { SafeAreaView } from 'react-native-safe-area-context' | |||
| import { ColorPallet } from '../../theme' | |||
There was a problem hiding this comment.
Theme items should come from useTheme so that themes from wallets that extend Bifold are used rather than just the base Bifold theme
| @@ -296,7 +298,7 @@ exports[`PINEnter Screen PIN Enter renders correctly 1`] = ` | |||
| "top": 0, | |||
| } | |||
| } | |||
| testID="com.ariesbifold:id/EnterPIN" | |||
| testID="com.ariesbifold:id/PINEnter.EnterPIN" | |||
There was a problem hiding this comment.
i18n entries should not be used for testIDs (this testID should remain the same)
| @@ -761,7 +1241,7 @@ exports[`PINEnter Screen PIN Enter renders correctly when logged out message is | |||
| "top": 0, | |||
| } | |||
| } | |||
| testID="com.ariesbifold:id/EnterPIN" | |||
| testID="com.ariesbifold:id/PINEnter.EnterPIN" | |||
| accessibilityLabel={ | ||
| usage === PINEntryUsage.PINCheck ? t('PINEnter.AppSettingChangedEnterPIN') : t('PINEnter.EnterPIN') | ||
| } | ||
| testID={testIdWithKey(inputLabelText[usage])} |
There was a problem hiding this comment.
A label is being used here rather than a testID, I think this is why the snapshot had that change I commented on.
| @@ -57,19 +58,19 @@ const PINEnter: React.FC<PINEnterProps> = ({ setAuthenticated, usage = PINEntryU | |||
| const [inlineMessageField, setInlineMessageField] = useState<InlineMessageProps>() | |||
| const [inlineMessages] = useServices([TOKENS.INLINE_ERRORS]) | |||
| const [alertModalMessage, setAlertModalMessage] = useState('') | |||
| // Temporary until all use cases are built with the new design | |||
There was a problem hiding this comment.
Still have this question. Do you mean all extensions of Bifold or all uses of the PINEnter screen? Is PINEntryUsage.PINCheck eventually going to be the same as PINEntryUsage.ChangeBiometrics?
LippaC-OPS
force-pushed
the
feat/enter-pin-biometrics-ui-update
branch
from
95c4854 to
900c983
Compare
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
Signed-off-by: Christian Lippa <[email protected]>
bryce-mcmath
force-pushed
the
feat/enter-pin-biometrics-ui-update
branch
from
3bf49e4 to
b1b0c95
Compare
|
Summary of Changes
Updated UI for the Enter PIN modal for the biometrics change flow. This PR also fixes the white space that was showing up on the bottom of the Enter PIN modal
Screenshots, videos, or gifs
Breaking change guide
N/A
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓