♻️ Refactor EventBus notify method #3690
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shoot — sorry, didn’t see that this was draft. Should have waited for the tests to complete before merging in main. Doh... |
ff137
force-pushed
the
improve-event-bus-notify
branch
from
90b5a7d to
6f2454f
Compare
- Streamlined the process of notifying subscribers by using a list comprehension for creating partials. - Added logging for cases where no subscribers are found for an event. - Enhanced error handling by logging exceptions that occur during the scheduling of notification tasks. - Introduced a new method to log exceptions in background notification tasks. - Non-blocking event notifications. This refactor aims to improve code performance and maintainability Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧
Relates to #3659