Several formats' prepare(): Fix bugs when checking fields #5776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogin fields[0] is never NULL, and the string it points to is only a nullstring if there is an explicit field saying so (i.e. line starts with a ":") For a missing login field (no ":", bare hash) field[0] is set to "?" in loader. This bug made the formats make up uncrackable hashes instead of rejecting when salt is unknown - leading to false negatives.
fields[n] is never NULL so no test for that needed. The intended checks were otherwise typically to check that a field wasn't an empty string.
solardiz
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fields[n] is never NULL, and the string fields[0] points to is only a nullstring if there is an explicit field saying so (i.e. line starts with a ":")
For a missing login field (no ":", bare hash) fields[0] is set to "?" in loader.
This bug made some formats make up uncrackable hashes from thin air instead of rejecting when salt is unknown - leading to false negatives. Those formats are in a separate commit.
This was tested manually and with Test Suite.