Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconf: fix arch.h selection for arm* #5632

Merged

Conversation

claudioandre-br
Copy link
Member

As it is now, it ends up picking arm32le.h on Android.

Configured for building John the Ripper jumbo:
Target CPU ......................................... arm, 64-bit LE
Target OS .......................................... linux-gnueabi
Cross compiling .................................... no
Legacy arch header ................................. arm32le.h

Tested (because of #5631, I have to force SIMD disabled):

Target CPU ......................................... arm (SIMD disabled), 64-bit LE
Target OS .......................................... linux-gnueabi
Cross compiling .................................... no
Legacy arch header ................................. arm64le.h

It ends up picking arm32le.h on Android.

Signed-off-by: Claudio André <[email protected]>
Copy link
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. I fixed this same problem in d6c8792 but apparently only for SIMD.

@magnumripper
Copy link
Member

Tested this on Macbook, problem triggered when using --disable-simd, and it was fixed with this commit

@magnumripper magnumripper merged commit 7b0aefd into openwall:bleeding-jumbo Dec 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants