Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue With Added Tokens #357

Merged
merged 1 commit into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/openvino_tokenizers/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class UTF8ReplaceMode(Enum):

def __str__(self):
return self.value

def __eq__(self, other):
if isinstance(other, (UTF8ReplaceMode)):
# UTF8ReplaceMode is a singleton, so we can compare them by reference
Expand Down
16 changes: 11 additions & 5 deletions python/openvino_tokenizers/hf_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ def tokenization_model(self) -> None:
"TemplateProcessing": CombineSegmentsStep.from_hf_json_template_postprocessor,
"BertProcessing": CombineSegmentsStep.from_hf_json_bert_postprocessor,
"RobertaProcessing": CombineSegmentsStep.from_hf_json_roberta_processor,
"ByteLevel": lambda *args: list(), # return no handle for ByteLevel so add_steps skips it
}

def post_tokenization(self) -> None:
Expand All @@ -297,17 +296,22 @@ def post_tokenization(self) -> None:

if pt_type == "Sequence":
processors = post_processor_json["processors"]
byte_level = next(
([] for step in processors if (step["type"] == "ByteLevel")),
None,
)
combine_segments_step = next(
(
self.post_tokenization_map[step["type"]](step, self.number_of_inputs, self.add_special_tokens)
step_class(step, self.number_of_inputs, self.add_special_tokens)
for step in processors
if step["type"] in self.post_tokenization_map
if (step_class := self.post_tokenization_map.get(step["type"]))
),
None,
)
combine_segments_step = combine_segments_step or byte_level
if combine_segments_step is None:
raise OVTypeError(
"Expected that Sequence post-tokenizer type contains one of supported post-tokenizers type:"
"Expected that Sequence post-tokenizer type contains one of supported post-tokenizers type: "
f"{list(self.post_tokenization_map)}"
)
else:
Expand Down Expand Up @@ -376,7 +380,9 @@ def decoding(self) -> None:
return

skip_tokens = parse_special_tokens(self.original_tokenizer)
self.pipeline.add_steps(VocabDecoderStep(skip_tokens=list(skip_tokens), do_skip_tokens=self.skip_special_tokens))
self.pipeline.add_steps(
VocabDecoderStep(skip_tokens=list(skip_tokens), do_skip_tokens=self.skip_special_tokens)
)

if self.tokenizer_json["decoder"]["type"] == "Sequence":
for decoder_dict in self.tokenizer_json["decoder"]["decoders"]:
Expand Down
2 changes: 1 addition & 1 deletion python/openvino_tokenizers/tokenizer_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from typing import Any, Dict, Iterable, List, Optional, Tuple, Union

import numpy as np
from openvino.runtime import Model, Output, PartialShape, Type, op, Shape
from openvino.runtime import Model, Output, PartialShape, Shape, Type, op
from openvino.runtime import opset12 as opset
from openvino.runtime.exceptions import OVTypeError, UserInputError
from openvino.runtime.utils.types import as_node, make_constant_node
Expand Down
2 changes: 1 addition & 1 deletion python/openvino_tokenizers/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import logging
import re
from dataclasses import dataclass, fields, field
from dataclasses import dataclass, field, fields
from functools import lru_cache
from typing import Any, Dict, Optional, Sequence, Tuple, Union

Expand Down
Loading