Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated assign_issues.yml #29068

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated assign_issues.yml #29068

wants to merge 4 commits into from
+101 −16

Conversation

Captain-MUDIT
Copy link

Details:

  • I have made the changes in the github workflow so that it updates the Good first issue board when an issue is asssigned or unassigned. It is also triggered by .take and .release .
  • ...

@Captain-MUDIT Captain-MUDIT requested a review from a team as a code owner February 19, 2025 12:14
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Feb 19, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Feb 19, 2025
@mlukasze mlukasze linked an issue Feb 20, 2025 that may be closed by this pull request
[Good First Issue]: Automate the Good First Issues board - "Assigned" column #20210
Open
@mlukasze mlukasze requested a review from p-wysocki February 20, 2025 05:49
akladiev
akladiev reviewed Feb 20, 2025
View reviewed changes
.github/workflows/assign_issue.yml Outdated

permissions: read-all
permissions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move the "permissions" section under "jobs" section, like described here? It will allow us to comply with our security requirements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, it is better to leave permissions: read-all by default for all jobs and set write permissions for particular jobs only

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure

akladiev
akladiev reviewed Feb 20, 2025
View reviewed changes
.github/workflows/assign_issue.yml Outdated
- name: take an issue
uses: bdougie/take-action@1439165ac45a7461c2d89a59952cd7d941964b87 # v1.6.1
- name: Process issue
uses: actions/github-script@v6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/github-script@v6
uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 #v6

@akladiev akladiev requested review from akashchi, ababushk and a team February 20, 2025 07:53
@akladiev akladiev mentioned this pull request Feb 20, 2025
Open
@mryzhov mryzhov requested a review from jacekpawlak February 20, 2025 09:05
@mryzhov
Copy link
Contributor

mryzhov commented Feb 20, 2025

@jacekpawlak could you please take a look at the PR

mryzhov
mryzhov reviewed Feb 20, 2025
View reviewed changes
.github/workflows/assign_issue.yml
trigger: .take
token: ${{ secrets.GITHUB_TOKEN }}
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is not small one, maybe it is better to wrap it into the custom JS action?
And it could be merged with #28491

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is an alternative to #28491, only one should be merged.

@p-wysocki
Copy link
Contributor

p-wysocki commented Feb 20, 2025 •
edited
Loading

Thank you for your contribution!

This PR is an alternative to #28491. The main difference is that this one is triggered by .take and .release commands, while the linked one is triggered by actual assignment/unassignment.

If we choose this one, the automation is not fully fool-proof. If someone drops a task and unassigns themselves, the issue will still be in "Assigned" column. We can't rely on people writing .release, when they still haven't gotten fully used to .take (especially that we're getting new contributors every month).

@Captain-MUDIT can this script be modified to be triggered by actual assign and unassign actions? Similar to how it's done in #28491.

@Captain-MUDIT
Copy link
Author

Thank you for your contribution!

This PR is an alternative to #28491. The main difference is that this one is triggered by .take and .release commands, while the linked one is triggered by actual assignment/unassignment.

If we choose this one, the automation is not fully fool-proof. If someone drops a task and unassigns themselves, the issue will still be in "Assigned" column. We can't rely on people writing .release, when they still haven't gotten fully used to .take (especially that we're getting new contributors every month).

@Captain-MUDIT can this script be modified to be triggered by actual assign and unassign actions? Similar to how it's done in #28491.

Ok I will do the necessary changes.

@Captain-MUDIT
Copy link
Author

I have made the changes as mention please review them and let me know if I need to do any further changes.

@Captain-MUDIT
Copy link
Author

@p-wysocki @akladiev can you please review the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akladiev akladiev akladiev left review comments

@mryzhov mryzhov mryzhov left review comments

@jacekpawlak jacekpawlak jacekpawlak approved these changes

@p-wysocki p-wysocki Awaiting requested review from p-wysocki

@akashchi akashchi Awaiting requested review from akashchi

@ababushk ababushk Awaiting requested review from ababushk

Assignees
No one assigned
Labels
category: CI OpenVINO public CI ExternalPR External contributor github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Automate the Good First Issues board - "Assigned" column
6 participants
@Captain-MUDIT @mryzhov @p-wysocki @akladiev @jacekpawlak @sys-openvino-ci