Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RopeFusion to support Qwen model after SDPA to PA conversion. #28620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update RopeFusion to support Qwen model after SDPA to PA conversion. #28620

wants to merge 2 commits into from
+138 −18

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Jan 22, 2025 •
edited by dorloff
Loading

Details:
Update RopeFusion for qwen model

Tickets:
CVS-161067

@itikhono itikhono requested a review from a team as a code owner January 22, 2025 17:32
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Jan 22, 2025
@itikhono itikhono requested review from a team as code owners January 23, 2025 07:53
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 23, 2025
luo-cheng2021
luo-cheng2021 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@luo-cheng2021 luo-cheng2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CPU part, thanks.

@ilya-lavrenov ilya-lavrenov added this to the 2025.1 milestone Jan 23, 2025
@itikhono
Copy link
Contributor Author

itikhono commented Jan 23, 2025 •
edited
Loading

GPU plugin crashes after this change, it looks like we need to support "position ids" mode for Rope (Qwen) on GPU side
waiting updates from GPU team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CuriousPanCake CuriousPanCake CuriousPanCake approved these changes

@luo-cheng2021 luo-cheng2021 luo-cheng2021 approved these changes

@evkotov evkotov Awaiting requested review from evkotov

Assignees
No one assigned
Labels
category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations do_not_merge
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
4 participants
@itikhono @luo-cheng2021 @CuriousPanCake @ilya-lavrenov