[RTTI] Use OV dynamic cast on Android only #28519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Jankowski <[email protected]>
github-actions
bot
added
category: Core
|
Could you please add tests that even w/ wrong RTTI declaration (like in GenAI), such operations / transformations can work on non-Android platforms? |
ilya-lavrenov
approved these changes
Jan 20, 2025
praasz
approved these changes
Jan 20, 2025
Signed-off-by: Tomasz Jankowski <[email protected]>
…c-cast-on-android-only
Signed-off-by: Tomasz Jankowski <[email protected]>
Signed-off-by: Tomasz Jankowski <[email protected]>
…c-cast-on-android-only
Signed-off-by: Tomasz Jankowski <[email protected]>
t-jankowski
changed the title
Added. |
|
Can we merge? |
t-jankowski
removed
do not merge
do_not_merge
pr: needs tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
### Details: - Used standard dynamic casting under the hood of OV dynamic casting. It drops dependency on OPENVINO_RTTI. Applies to non Android. ### Tickets: - CVS-160749 ### Backport #28519 Signed-off-by: Tomasz Jankowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
OV dynamic casting causes issue in external software with badly formed OV RTTI definitions, so it's replaced with standard dynamic casting, except for Android.
Tickets: