New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] OV file utils file_size use std file path #28462

Open

barnasm1 wants to merge 40 commits into openvinotoolkit:master from barnasm1:ov_file_path_util_file_size

+384 −81

Contributor

barnasm1 commented Jan 15, 2025

Details:

refactor file_size function to accept ov::util::Path / std::filesystem::path. Be backward compatible with previous version.

Tickets:

146659

barnasm1 added 5 commits

January 15, 2025 15:18


          move wide character string conversions to separate file

887dd2b


          refactor

04671c7


          refactor file size functions to use ov::util::Path and handle Android…

b334528

… paths


          add unit tests for cut_android_path function

c0ec93e


          add unit tests for file size functions with various file types and en…

dce5d59

…codings

barnasm1 added the category: Core label

barnasm1 self-assigned this

barnasm1 requested review from a team as code owners

January 15, 2025 15:26

github-actions bot added the category: build label

barnasm1 and others added 4 commits

January 15, 2025 15:40


          code format

701cd96


          prevent variable redefinition for android

97f2a96


          refactor test to use ov::util::Path for Unicode file output

c0345b1


          Merge branch 'master' into ov_file_path_util_file_size

66615dc

praasz self-assigned this

praasz added this to the 2025.1 milestone


          add Windows-specific includes for wstring_cast_util

a1e8053

ilya-lavrenov reviewed

View reviewed changes

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/cpp_version.hpp Outdated Show resolved Hide resolved

barnasm1 added 2 commits

January 16, 2025 12:26


          fix comment typo

f34b2d2


          refactor cpp_version.hpp and file_path.hpp for compiler version checks

2d071bf

praasz reviewed

View reviewed changes

src/common/util/include/openvino/util/wstring_cast_util.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/cpp_version.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_util.hpp

    
            @@ -172,26 +161,30 @@ bool directory_exists(const std::string& path);
          
              bool directory_exists(const std::wstring& path);

              #endif

              inline ov::util::Path cut_android_path(const ov::util::Path& file_name) {

Contributor

praasz Jan 16, 2025

This function is not required can be still internal part of file_size

src/common/util/include/openvino/util/file_util.hpp Outdated Show resolved Hide resolved

src/core/tests/file_util.cpp Show resolved Hide resolved

src/core/tests/file_util.cpp Outdated Show resolved Hide resolved

src/core/tests/file_util.cpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_util.hpp Show resolved Hide resolved

src/common/util/include/openvino/util/wstring_cast_util.hpp Outdated Show resolved Hide resolved

t-jankowski requested changes

View reviewed changes

src/common/util/include/openvino/util/cpp_version.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/cpp_version.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

barnasm1 added 8 commits

January 16, 2025 11:57


          refactor WPath function to use lambda syntax, to meet Naming style check

3b2fbae


          update copyright year to 2025, fix typos,

eed127e

refactor to use structured bindings


          rename wstring_cast_util to wstring_convert_util and update includes

067224b


          add Android-specific file size test

22d6712


          fix typo in CMakeLists.txt for wstring_convert_util source file path

2e7cf52


          deprecate old file_size function and provide alternative usage guidance

e9c2cca


          update file size tests to use string literals

71e2206


          skip file size tests based on C++ version

c8bdb3b

ilya-lavrenov reviewed

View reviewed changes

src/common/util/include/openvino/util/file_util.hpp Outdated Show resolved Hide resolved


          revert: refactor WPath function to use lambda syntax, to meet Naming …

dd13c04

…style check

olpipi reviewed

View reviewed changes

src/common/util/include/openvino/util/file_util.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_util.hpp Outdated Show resolved Hide resolved

barnasm1 added 3 commits

January 21, 2025 09:57


          Merge branch 'master' into ov_file_path_util_file_size

74640d8


          clang format

0f2aa4a


          Merge branch 'master' into ov_file_path_util_file_size

76d0a49

mlukasze requested a review from t-jankowski

January 24, 2025 05:47

barnasm1 added 16 commits

January 27, 2025 13:03


          Merge branch 'master' into ov_file_path_util_file_size

f9cd47d


          Refactor namespace declaration

0794bcd


          Replace file size calculation with std::filesystem

8d745c5


          Refactor cut_android_path function for improved readability

a82aef0


          Remove deprecated file_size function

77dd50f


          Update file_size function to use ov::util namespace for consistency

d45867d


          Refactor file path handling and update file size functions

8837c2e


          Revert "Remove deprecated file_size function"

d9a9487

This reverts commit 77dd50f.


          Fix preprocessor directive formatting for GCC and Clang version checks

6c8b9a5


          Fix file_size function to handle Android paths correctly

8acae29


          Update file size tests to use string literals to avoid deprecation wa…

b45c26b

…rning message


          Add Unicode content tests for file size functionality

65cc6d5


          Add test for file size calculation of raw byte files

bab5a77


          Remove Unicode content tests and related setup from FileUtilTest

b8cf8dc


          cut_android_path function restrict

f4cb551


          check if cut_android_path is required at new impl

feab0bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build category: Core