[GPU] prevent too long sort in experimental detectron generate proposals single image #28422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like not fixed issue, still hang in specific case |
|
works |
michal-miotk
changed the title
|
Commit title is a bit too long. Second part of it should rather be in the description |
dnkurek
reviewed
Jan 16, 2025
...src/kernel_selector/cl_kernels/experimental_detectron_generate_proposals_single_image_ref.cl
Show resolved
Hide resolved
dnkurek
reviewed
Jan 16, 2025
...src/kernel_selector/cl_kernels/experimental_detectron_generate_proposals_single_image_ref.cl
Show resolved
Hide resolved
michal-miotk
changed the title
clee30
reviewed
Jan 16, 2025
| static int static_counter = 0; | ||
| static_counter++; | ||
| int pivot_idx = l; | ||
| if(static_counter%3 == 0) { |
There was a problem hiding this comment.
Why is 3 here? May be need to define it.
There was a problem hiding this comment.
Looks to me like a cyclic pivot selection rotation scheme in order to avoid worst case scenario in quicksort
There was a problem hiding this comment.
I guess that a simple comment may suffice so it's more clear
vladimir-paramuzov
approved these changes
Jan 16, 2025
|
on instance-segmentation-security-0050/FP32/instance-segmentation-security-0050.xml speedup from 1.55fps(0010b3b - ref) to 4.26 FPS [36bab31] , gpu uhd770, infer_precision=f32(ref version crash on f16) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
segmentation-security-0010.xml speed up 0.14fps->0.19fps
Tickets: