Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU][ARM]: Implemented CPU plugin just-in-time emitter for Negative operation #28258

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

xyz-harshal
Copy link
Contributor

Details:

  • Added JIT emitter for Eltwise Negation operation on ARM64 SIMD
  • Implemented fp32 optimization replacing C++ Math implementation
  • Modified ARM64 executor to support new JIT emitter
  • Updated kernel files to include Negation in Eltwise operations
  • Added test coverage for JIT implementation verification
  • Transitioned operation type from Math to Eltwise for better performance

Tickets:

image

@xyz-harshal xyz-harshal requested review from a team as code owners January 2, 2025 21:02
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 2, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 2, 2025
@xyz-harshal xyz-harshal closed this Jan 2, 2025
@xyz-harshal xyz-harshal reopened this Jan 3, 2025
@a-sidorova a-sidorova self-assigned this Jan 3, 2025
@a-sidorova a-sidorova added this to the 2025.0 milestone Jan 3, 2025
@a-sidorova a-sidorova added the platform: arm OpenVINO on ARM / ARM64 label Jan 3, 2025
@a-sidorova
Copy link
Contributor

build_jenkins

@a-sidorova
Copy link
Contributor

@xyz-harshal many x64 jobs are failed with the following error:

/__w/openvino/openvino/openvino/src/plugins/intel_cpu/src/nodes/eltwise.cpp:324:10:   required from here
/usr/include/c++/8/ext/new_allocator.h:136:4: error: no matching function for call to 'ov::intel_cpu::jit_negative_emitter::jit_negative_emitter(dnnl::impl::cpu::x64::jit_generator*&, dnnl::impl::cpu::x64::cpu_isa_t&, ov::element::Type&)'
  { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }

Could you please add the new constructor without const std::shared_ptr<ov::Node>& argument for jit_negative_emitter on x64 platforms here? It should fix the build on x64 devices.

@a-sidorova
Copy link
Contributor

build_jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin ExternalPR External contributor platform: arm OpenVINO on ARM / ARM64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Negative operation
3 participants