[GPU] Add check of multiple axis broadcasting in is_valid_fusion() when dynamic shape #28252
+107
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-durandin
approved these changes
Jan 2, 2025
|
Would be good to add test for this case |
yeonbok
reviewed
Jan 2, 2025
| @@ -2658,6 +2658,19 @@ bool primitive_inst::is_valid_fusion() const { | |||
| if (fd.is_type<eltwise>()) | |||
| can_broadcast = ov::PartialShape::broadcast_merge_into(merged_shape, outer_dep_pshape, fd.typed_desc<eltwise>()->broadcast_spec); | |||
|
|
|||
| // Check if broadcast happens more than single axis. | |||
| // Current FUSED_OP_LOAD macro cannot support broadcast on dynamic dimension. | |||
| if (can_broadcast == true && (merged_shape.is_static() && outer_dep_pshape.is_static()) && | |||
There was a problem hiding this comment.
Are these two conditions needed? At runtime, shapes should be static always.
There was a problem hiding this comment.
You are right, I removed it. Thanks!
yeonbok
reviewed
Jan 2, 2025
| // Check if broadcast happens more than single axis. | ||
| // Current FUSED_OP_LOAD macro cannot support broadcast on dynamic dimension. | ||
| if (can_broadcast == true && (merged_shape.is_static() && outer_dep_pshape.is_static()) && | ||
| outer_dep.first->_is_dynamic == true && merged_shape.rank().get_length() == outer_dep_pshape.rank().get_length()) { |
There was a problem hiding this comment.
outer_dep.first->_is_dynamic
Do we need this condition? even though it is not dynamic, the fusion is not allowed isn't it? And also this function is not called for static primitive.
There was a problem hiding this comment.
You are right. the is_valid_fusion() is called in dynamic shape case. I removed it. Thanks!
|
Please add a functional test. |
Added func test. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: