[GPU] fix memory conflict for multi iteration in loop. #28056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1009,6 +1009,12 @@ void loop_inst::set_memory_in_body_network(cldnn::network::ptr body_network, | |||
| "impl_params layout size(", impl_layout.to_short_string(), | |||
| ") should not exceed memory size(", updated_mem->get_layout().to_short_string(), ")"); | |||
| // Set need_to_check_memory_to_set to false to set output memory even if the input node has static shape, | |||
| if (impl_layout.bytes_count() < updated_mem->get_layout().bytes_count()) { | |||
There was a problem hiding this comment.
I think this check condition creates redundant memory copies in cases where there is no memory conflict.
There was a problem hiding this comment.
@timxu826 From the description, you seem to resolve memory conflicts issue?
If so, is this enough?
Shouldn't we prevent memory reuse for the problematic case?
|
build_jenkins |
|
build_jenkins |
|
build_jenkins |
github-actions
bot
added
category: transformations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause is shown in graph below.
The black, green, and dotted line donates the primitive dependency, memory buffer reuse, and memory conflict (at the second iteration) respectively.
The body of the loop is compiled as a separate model and is not aware the data reuse in backedge in multiple iteration.
Tickets: