Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Value Optimization #27555

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Partial Value Optimization #27555

wants to merge 20 commits into from
+170 −81

Conversation

jane-intel
Copy link
Contributor

Details:

  • Partial Value optimization was already capable of optimizing multiple value sources. This time we strive to reuse singular values in the construction of multi-values so that we minimize ShapeOf op number and minimize ShapeOf sub-graphs. Additionally, this time we prioritize static values over symbol for the case when value has both

@jane-intel
Partial Value optimization
0e6fb21 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel jane-intel requested a review from a team as a code owner November 14, 2024 09:34
@jane-intel jane-intel requested review from itikhono and removed request for a team November 14, 2024 09:34
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Nov 14, 2024
@jane-intel
style
6110c67 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel
too early for ShapeOf replacements
dab2af5 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel
Merge remote-tracking branch 'upstream/master' into partial_value_opt…
7a66c26 
…imization

Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel
review comments
14e9f63 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel jane-intel requested a review from praasz November 21, 2024 08:43
praasz
praasz reviewed Nov 22, 2024
View reviewed changes
src/common/transformations/src/transformations/symbolic_transformations/symbol_optimization.cpp
continue;
auto symbol = d.get_symbol();
if (symbol == nullptr)
if (d.is_static() || d.get_symbol() == nullptr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (d.is_static() || d.get_symbol() == nullptr)
if (d.is_static() || !d.has_symbol())

Maybe has_symbol should be updated and static Dimension shouldn't have symbol?

@jane-intel jane-intel requested review from a team as code owners November 23, 2024 07:36
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Dec 22, 2024
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Dec 23, 2024
@jane-intel
Fix build
7c183db 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel
Merge remote-tracking branch 'upstream/master' into partial_value_opt…
e22d3b6 
…imization

Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel jane-intel requested a review from praasz December 26, 2024 07:35
@github-actions github-actions bot removed the Stale label Dec 27, 2024
@jane-intel
test
9a10ad5 
Signed-off-by: Evgeniia Nugmanova <[email protected]>
@jane-intel
Merge remote-tracking branch 'upstream/master' into partial_value_opt…
c990a8c 
…imization

Signed-off-by: Evgeniia Nugmanova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itikhono itikhono itikhono approved these changes

@praasz praasz Awaiting requested review from praasz

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jane-intel @itikhono @praasz