[CPU][ARM64] Added Less JIT emitter #25059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support and unit test for Less jit emitter
github-actions
bot
added
category: IE Tests
eshoguli
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Thanks for your contribution.
- You need to specify
jitkernel in test as expected kernel. - Can you, please, update
ActivationLayerCPUTest::generate_inputsto coverLessemitter functionality. There is an example forSignactivation. You can do something similar but use more then one value, please:- Two input tensor values should be different: less, equal and greater.
- Please, update to have special values: negative zero, NaN (several values), Infinity values, ... in test input tensor.
Comment on lines
+632
to
+639
| template<> | ||
| struct EltwiseEmitter<jit_less_emitter> { | ||
| void operator()(EltwiseEmitterContext& ctx) { | ||
| ctx.emitter = std::make_shared<jit_less_emitter>(ctx.host, | ||
| ctx.host_isa, | ||
| ctx.exec_prc); | ||
| } | ||
| }; |
|
hey @jvr0123 will you have a time to finish this PR? |
Yes, apologies, I'll have an update after this weekend |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
hey @jvr0123 - please update a status of the PR, will you have a time to finish it? |
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: