Use whole history in case of undetermined tokenization of sequence #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: visual language
sbalandi
force-pushed
the
tok_hist
branch
2 times, most recently
from
49a4c9b to
05b3302
Compare
Wovchena
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Not for this PR, but we need tests for that change. I remember you said random miniCPM diverges. This PR probably fixes that, so your case can be used as a test for VLM. LLM needs its test as well, maybe you can provoke a random weights model to generate such tokens.
|
comments have been addressed - #1268 |
|
Let's sync with #1268 and address remaining comments from that PR if they are valid |
sbalandi
force-pushed
the
tok_hist
branch
3 times, most recently
from
ddd706c to
266c4b6
Compare
ilya-lavrenov
approved these changes
Dec 13, 2024
Wovchena
requested changes
Dec 13, 2024
src/cpp/src/utils.cpp
Outdated
| ov::Tensor old_tensor = state.get_state(); | ||
| // [BATCH_SIZE, num_kv_heads, seq_len, head_size] | ||
| auto shape = old_tensor.get_shape(); | ||
| shape[2] -= remove_from_end; |
There was a problem hiding this comment.
Unfortunately, sequence is represented by another dimension sometimes. See
There was a problem hiding this comment.
thanks for the point, added runtime search seq_len_axis
sbalandi
force-pushed
the
tok_hist
branch
2 times, most recently
from
c12aee5 to
05305e3
Compare
Wovchena
approved these changes
Dec 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: CVS-157295