Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two separate pools for unary and streaming, ram usage mitigation #2971

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Two separate pools for unary and streaming, ram usage mitigation #2971

wants to merge 10 commits into from
+92 −35

Conversation

dkalinowski
Copy link
Collaborator

🛠 Summary

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.

@dkalinowski dkalinowski added WIP Do not merge until resolved DO NOT MERGE labels Jan 17, 2025
@dkalinowski dkalinowski force-pushed the pool branch 4 times, most recently from 2bc3355 to de79ca6 Compare January 21, 2025 15:24
atobiszei
atobiszei reviewed Jan 22, 2025
View reviewed changes
src/config.cpp
@@ -38,7 +38,7 @@ namespace ovms {
const uint32_t AVAILABLE_CORES = getCoreCount();
const uint32_t MAX_PORT_NUMBER = std::numeric_limits<uint16_t>::max();

const uint64_t DEFAULT_REST_WORKERS = AVAILABLE_CORES * 4.0;
const uint64_t DEFAULT_REST_WORKERS = AVAILABLE_CORES;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#IF DROGON=1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, done

@dtrawins dtrawins added this to the 2025.0_RC milestone Jan 23, 2025
@dkalinowski dkalinowski removed WIP Do not merge until resolved DO NOT MERGE labels Jan 23, 2025
@dkalinowski dkalinowski force-pushed the pool branch 2 times, most recently from 380cfae to 5becb3d Compare January 23, 2025 12:41
@dkalinowski dkalinowski added WIP Do not merge until resolved DO NOT MERGE labels Jan 24, 2025
@dkalinowski dkalinowski force-pushed the pool branch 2 times, most recently from 9bf56ae to 67c2ffa Compare January 27, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atobiszei atobiszei atobiszei approved these changes

@dtrawins dtrawins dtrawins approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE WIP Do not merge until resolved
Projects
None yet
Milestone
2025.0_RC
Development

Successfully merging this pull request may close these issues.
3 participants
@dkalinowski @dtrawins @atobiszei