Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVS-154700, Implement LoadLibrary for windows with GetProcAddress #2874

Merged
merged 12 commits into from
Jan 7, 2025

Conversation

18582088138
Copy link
Collaborator

@18582088138 18582088138 commented Nov 25, 2024

🛠 Summary

Implement LoadLibrary for windows with GetProcAddress - dlopen.
JIRA/Issue : CVS-154700

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copy link
Collaborator

@rasapala rasapala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable skipped tests: NodeLibraryManagerTest

@rasapala rasapala requested a review from bstrzele January 3, 2025 13:45
std::string basePath = bazelOutIndex != std::string::npos ? cwd.string().substr(0, bazelOutIndex) : cwd.string();
// Combine "C:\git\model_server\" + "/bazel-bin/src"
std::string finalWinPath = basePath + winPath;
// Change paths to linux separator for JSON parser compatyility in configs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Change paths to linux separator for JSON parser compatyility in configs
// Change paths to linux separator for JSON parser compatibility in configs

@18582088138 18582088138 merged commit f530f85 into main Jan 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants