Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in notebooks when running from E2E tests #522

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Fix errors in notebooks when running from E2E tests #522

merged 9 commits into from
Nov 21, 2024

Conversation

Daankrol
Copy link
Collaborator

Changes in this PR:

  • Project deployment by name raised error as it expected project object. Fixes several notebooks
  • Wait for job to appear in job queue before checking job status.
  • Project deletion after creation in notebook would raise error because job creation kafka event was not yet done. Commented out the delete operation in the cell so E2E tests can test the notebook

rajeshgangireddy
rajeshgangireddy approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@rajeshgangireddy rajeshgangireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ljcornel ljcornel merged commit 0b760a0 into releases/v2.5.0 Nov 21, 2024
10 checks passed
@ljcornel ljcornel deleted the daan/v2.5.0-backport-fixes branch November 21, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajeshgangireddy rajeshgangireddy rajeshgangireddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daankrol @rajeshgangireddy @ljcornel