Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ioniq 5 - Simplify & Improve 12V monitor #1052

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Ioniq 5 - Simplify & Improve 12V monitor #1052

merged 1 commit into from
Nov 10, 2024

Conversation

frogonwheels
Copy link
Contributor

  • Use short(4) and long(8) smoothed average comparison
  • Detects a dip while 12V charging as well.
  • Only polls while charging if it detects dip or after a longer period
  • Factor out to functions

@frogonwheels frogonwheels marked this pull request as draft August 23, 2024 09:53
@frogonwheels
Copy link
Contributor Author

There are some reported issues with the hard-coded values in this patch that need to be resolved.

@dexterbg
Copy link
Member

Michael, not going to merge this yet, as it's tagged being a draft & also needs conflict resolution now.

@frogonwheels
Copy link
Contributor Author

frogonwheels commented Aug 30, 2024 via email

@frogonwheels
Ioniq 5 - Simplify & Improve 12V monitor
b5781c6 
- Use short(4) and long(8) smoothed average comparison
- Detects a dip while 12V charging as well.
- Only polls while charging if it detects dip or after a longer period
- Factor out to functions
@frogonwheels frogonwheels marked this pull request as ready for review November 9, 2024 09:04
@dexterbg dexterbg merged commit ecf548f into openvehicles:master Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frogonwheels @dexterbg