Cap tensorflow version to < 2.18. #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't support (yet).
|
My understanding is that TF 2.18 also supports numpy v1, so imo, it would be better to pin numpy, until it's supported. |
|
Good call, didn't realize that - would you mind updating your PR to also
constrain the numpy version in setup.py (instead of just requirements.txt)?
Thanks.
…On Fri, Nov 8, 2024 at 10:54 AM Neil Dalchau ***@***.***> wrote:
My understanding is that TF 2.18 also supports numpy v1, so imo, it would
be better to pin numpy, until it's supported.
—
Reply to this email directly, view it on GitHub
<#247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADSHODGKHQFJGH7IVEBS2DZ7TNDZAVCNFSM6AAAAABRNYEUVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGEYDAOBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Closing in favor of #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF 2.18 uses numpy 2.0, which we don't support (yet).
Related: #245 #246