Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SIRI's StopPointRef to refer to a NeTEx scheduled stop point #6397

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jan 17, 2025

Summary

Even though the various documents on SIRI and NeTEx are quite unclear, even contradictory what exactly an EstimatedCall's StopPointRef should refer to, all the experts agree that a scheduled stop point is a valid target (as an alternative to the quay).

We discussed this at length at https://public.3.basecamp.com/p/TcEEP5WrNZJPBxrJU9GAjint

For this reason, this adds support for SIRI to refer to scheduled stop point.

Issue

Closes #6340

Unit tests

I added some for the EntityResolver and the TimetableRepository.

Documentation

I didn't want to duplicate the documentation for this in several places so I opted to document it in the innermost layer (TimetableRepository) and link to it in other places.

Bumping the serialization version id

✔️

cc @rcavaliere

@leonardehrenfried leonardehrenfried added the bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR label Jan 17, 2025
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner January 17, 2025 16:28
@leonardehrenfried leonardehrenfried force-pushed the siri-scheduled-stop-point branch from fbeaa89 to 59bf199 Compare January 17, 2025 16:31
@leonardehrenfried leonardehrenfried added the Real-Time Update The issue/PR is related to RealTime updates label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (448ad8f) to head (b69d085).
Report is 252 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...anner/netex/loader/parser/NetexDocumentParser.java 78.57% 1 Missing and 2 partials ⚠️
...lanner/netex/loader/parser/ServiceFrameParser.java 0.00% 1 Missing and 1 partial ⚠️
...planner/transit/service/DefaultTransitService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6397      +/-   ##
=============================================
+ Coverage      69.72%   69.87%   +0.14%     
- Complexity     18016    18126     +110     
=============================================
  Files           2057     2069      +12     
  Lines          76967    77262     +295     
  Branches        7844     7844              
=============================================
+ Hits           53666    53984     +318     
+ Misses         20550    20524      -26     
- Partials        2751     2754       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried force-pushed the siri-scheduled-stop-point branch from fe49b6f to 8470f8c Compare January 20, 2025 16:14
@optionsome optionsome requested a review from vpaturet January 21, 2025 10:25
@t2gran t2gran added this to the 2.7 (next release) milestone Jan 29, 2025
@leonardehrenfried leonardehrenfried merged commit 59dd11e into opentripplanner:dev-2.x Feb 5, 2025
6 checks passed
t2gran pushed a commit that referenced this pull request Feb 5, 2025
t2gran pushed a commit that referenced this pull request Feb 5, 2025
@leonardehrenfried leonardehrenfried deleted the siri-scheduled-stop-point branch February 7, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Real-Time Update The issue/PR is related to RealTime updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIRI references pointing to ScheduledStopPoint instead of Quay
4 participants