-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SIRI's StopPointRef to refer to a NeTEx scheduled stop point #6397
Merged
leonardehrenfried
merged 6 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:siri-scheduled-stop-point
Feb 5, 2025
Merged
Allow SIRI's StopPointRef to refer to a NeTEx scheduled stop point #6397
leonardehrenfried
merged 6 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:siri-scheduled-stop-point
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeaa89
to
59bf199
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6397 +/- ##
=============================================
+ Coverage 69.72% 69.87% +0.14%
- Complexity 18016 18126 +110
=============================================
Files 2057 2069 +12
Lines 76967 77262 +295
Branches 7844 7844
=============================================
+ Hits 53666 53984 +318
+ Misses 20550 20524 -26
- Partials 2751 2754 +3 ☔ View full report in Codecov by Sentry. |
9d0108a
to
fe49b6f
Compare
fe49b6f
to
8470f8c
Compare
habrahamsson-skanetrafiken
requested changes
Feb 3, 2025
application/src/main/java/org/opentripplanner/netex/mapping/NetexMapper.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/siri/EntityResolver.java
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/siri/EntityResolver.java
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/siri/EntityResolver.java
Show resolved
Hide resolved
habrahamsson-skanetrafiken
approved these changes
Feb 4, 2025
vpaturet
approved these changes
Feb 5, 2025
t2gran
pushed a commit
that referenced
this pull request
Feb 5, 2025
t2gran
pushed a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Real-Time Update
The issue/PR is related to RealTime updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even though the various documents on SIRI and NeTEx are quite unclear, even contradictory what exactly an EstimatedCall's
StopPointRef
should refer to, all the experts agree that a scheduled stop point is a valid target (as an alternative to the quay).We discussed this at length at https://public.3.basecamp.com/p/TcEEP5WrNZJPBxrJU9GAjint
For this reason, this adds support for SIRI to refer to scheduled stop point.
Issue
Closes #6340
Unit tests
I added some for the EntityResolver and the TimetableRepository.
Documentation
I didn't want to duplicate the documentation for this in several places so I opted to document it in the innermost layer (TimetableRepository) and link to it in other places.
Bumping the serialization version id
✔️
cc @rcavaliere