Fix one-way boarding location processing

[miklcct]

PR Instructions

Summary

This adds @Nullable annotations to StreetEdge and its users.

It also fixes the processing for linear one-way platforms which crashed OSM ( https://www.openstreetmap.org/way/656712860 )

Issue

#6387

Unit tests

The original code can't be unit tested but can only be tested by using OSM data, which I added one test for it.

Documentation

None needed

Changelog

None

Bumping the serialization version id

None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.74%. Comparing base (4c3983b) to head (4849d5b).
Report is 101 commits behind head on dev-2.x.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #6388   +/-   ##
==========================================
  Coverage      69.73%   69.74%           
- Complexity     17957    17960    +3     
==========================================
  Files           2049     2049           
  Lines          76756    76757    +1     
  Branches        7832     7832           
==========================================
+ Hits           53529    53533    +4     
+ Misses         20493    20491    -2     
+ Partials        2734     2733    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

@miklcct I experimented with making OsmModule more testable: leonardehrenfried@a8adf06

I think it's the right way to go.

Can you clean this up and add the correct test cases?

• move the provider into a separate file in a _support directory
• add nodes to the way
• ...

[leonardehrenfried]

Here is the complete setup: https://github.com/leonardehrenfried/OpenTripPlanner/tree/testable-osm

Can you take it do some clean up?

[leonardehrenfried]

What I missed in the previous review: we don't actually need to store a Platform if it doesn't contain any references. Can you implement it in this method?

OpenTripPlanner/application/src/main/java/org/opentripplanner/graph_builder/module/osm/OsmModule.java

Lines 449 to 474 in a8adf06

	private Optional<Platform> getPlatform(OsmWay way) {
	if (way.isBoardingLocation()) {
	var nodeRefs = way.getNodeRefs();
	var size = nodeRefs.size();
	var nodes = new Coordinate[size];
	for (int i = 0; i < size; i++) {
	nodes[i] = osmdb.getNode(nodeRefs.get(i)).getCoordinate();
	}
	var geometryFactory = GeometryUtils.getGeometryFactory();
	var geometry = geometryFactory.createLineString(nodes);
	var references = way.getMultiTagValues(params.boardingAreaRefTags());
	return Optional.of(
	new Platform(
	params.edgeNamer().getNameForWay(way, "platform " + way.getId()),
	geometry,
	references
	)
	);
	} else {
	return Optional.empty();
	}
	}