Fix max search-window when paging #6189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
added
Bug
Documentation
Entur Test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6189 +/- ##
==========================================
Coverage 69.90% 69.90%
+ Complexity 17723 17722 -1
==========================================
Files 1998 1998
Lines 75443 75453 +10
Branches 7718 7718
==========================================
+ Hits 52740 52748 +8
- Misses 20025 20026 +1
- Partials 2678 2679 +1 ☔ View full report in Codecov by Sentry. |
The PagingService was initialized with the dynamic max-search-window value, and not the request max search-window. This commit also updates the Transmodel API doc.
eibakke
reviewed
Oct 23, 2024
application/src/main/java/org/opentripplanner/apis/transmodel/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
eibakke
reviewed
Oct 23, 2024
application/src/main/java/org/opentripplanner/apis/transmodel/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
eibakke
reviewed
Oct 23, 2024
...n/src/main/java/org/opentripplanner/standalone/config/routerconfig/TransitRoutingConfig.java
Outdated
Show resolved
Hide resolved
eibakke
reviewed
Oct 24, 2024
application/src/main/java/org/opentripplanner/apis/transmodel/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opentripplanner/standalone/config/routerconfig/TransitRoutingConfig.java
Outdated
Show resolved
Hide resolved
eibakke
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PagingService was initialized with the dynamic max-search-window value, and not the request max search-window. This commit also updates the Transmodel API doc.
Issue
This was reported at Entur yesterday. It is a minor fix, so I have not created an issue for it.
Unit tests
This was an error in the wiring of the application - creating a good test for this is expensive and give little value.
Documentation
✅ The Transmodel API doc is updated.
✅ JavaDoc and code comments is updated/added
🟥 The GTFS API is not updated - someone who knows the API should do this
Changelog
✅
Bumping the serialization version id
Not needed.