fix out of bounds when fetching NextLegs #6136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach has some issues and needs to be discussed in the developer meeting. |
|
As discussed in the developer meeting I am going to work on the shape generation at the point of generating new pattern. |
miklcct
force-pushed
the
fix-nextLeg-outOfBounds
branch
from
56131a8
to
2dfaddf
Compare
miklcct
force-pushed
the
fix-nextLeg-outOfBounds
branch
from
2dfaddf
to
8753f82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6136 +/- ##
=============================================
- Coverage 69.93% 69.91% -0.03%
+ Complexity 17730 17729 -1
=============================================
Files 1996 1998 +2
Lines 75402 75451 +49
Branches 7717 7724 +7
=============================================
+ Hits 52731 52749 +18
- Misses 19995 20025 +30
- Partials 2676 2677 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such geometries may happen when a replacement trip partially uses the original geometry.
Summary
Fix out of bounds under period of train disruption. The problem occurs when fetching geometries for a stop further than the geometry which may happen when a replacement trip partially uses the geometry.
Issue
Fixes #6072.
Unit tests
Added.
Documentation
None needed.