Pass and close scope directly #88
Conversation
Avoid using ScopeManager.active() as some tracer implementations return different scope with invalid scope.close() method. Signed-off-by: Pavol Loffay <[email protected]>
|
@jmif hi, could you please test this PR if it solves your issue? |
There was a problem hiding this comment.
This doesn't feel right - working around the fact that a tracer doesn't implement the spec correctly. This would mean that potentially all instrumentations would need to change.
If there is an issue with the spec/API, then it should be discussed in the OT community and changes applied to the API if appropriate, which should then be implemented in the instrumentations.
|
Indeed, there are problems with other instrumentations if the tracer does not implement scopes correctly. API issue is here opentracing/opentracing-java#267. I agree that it's better to manage and pass the scope explicitly in the component where it was created. This change has no impact on functionality, I would like to get it merged anyway. It would be good that you post your opinion in #88 (review) and/or linked issue to brave-ot. |
|
@objectiser thanks I have cut a new release 0.1.6 |
Fixes #87
Avoid using ScopeManager.active() as some
tracer implementations return different scope
with invalid scope.close() method.
Signed-off-by: Pavol Loffay [email protected]