Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

#68 - Camera does not get reclaimed #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wolfenrain
Copy link

Contributing checklist

  • Code must follow existing styling conventions
  • Added a descriptive commit message

Solves issue(s)

#68

@mark-veenstra mark-veenstra mentioned this pull request May 7, 2018
2 tasks
@msach22
Copy link

msach22 commented May 17, 2018

Thanks for this PR. I spoke to one of our native developers and we both believe this should be application logic and not a part of this plugin. We don't want to tie the camera to the publisher because it's also possible to have a custom capturer that's not a camera, but is used for other things such as screen sharing.

@wolfenrain
Copy link
Author

@msach22 Correct me if I am wrong, but how would one manage to do that on application level without writing a native plugin? Let alone hook into the OpenTok plugin to use the mPublisher.setPublishVideo method. I can understand that you can unpublish when going into background.. and publish when coming back...

I do belief this should be in the plugin, because we want to allow people to keep on publishing when in background, but also allow app creators to let their users use a different camera app(like snapchat) and then returning to publishing/reclaiming automatically.

@mheap mheap changed the base branch from master to main March 22, 2021 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants