This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
forked from msach22/cordova-plugin-opentok
-
Notifications
You must be signed in to change notification settings - Fork 80
Fixes for Cordova 9 #174
Open
dopplerDistortion
wants to merge
7
commits into
opentok:main
Choose a base branch
from
dopplerDistortion:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes for Cordova 9 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthonyzou
approved these changes
Sep 30, 2019
Can we please merge this? I am facing the same issue. People have moved on from cordova 8. |
@Anthonyzou when can we expect to get it merged? |
allnash
approved these changes
Oct 3, 2019
@jamesdehart who is responsible at OpenTok to approve merge PR's? |
Seems like nobody :( |
ammarax
approved these changes
Nov 6, 2019
ammarax
approved these changes
Nov 6, 2019
omiwrench
approved these changes
Nov 8, 2019
dg9523
approved these changes
Nov 8, 2019
Any update on when this support will be merged? |
Patrick-Ullrich
approved these changes
Nov 25, 2019
kspevak
added a commit
to trainer-rx/cordova-plugin-opentok
that referenced
this pull request
Nov 27, 2019
mozhn
approved these changes
Feb 4, 2020
mozhn
approved these changes
Feb 4, 2020
Can this PR be merged? Would be highly appreciated! |
lempere
approved these changes
Mar 27, 2020
@michaeljolley - can anybody look at this ? |
@michaeljolley can we get this merged? |
albalooshi
approved these changes
Apr 30, 2020
assafshp
reviewed
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please merge ?
henritoivar
approved these changes
May 25, 2020
ziomarco
approved these changes
Jul 3, 2020
can we get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue(s)
q library added to package.json
context.requireCordovaModule('q') functions changed to require('q')
#165