Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publisheronly token role #272

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Add publisheronly token role #272

merged 4 commits into from
Apr 22, 2024

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Apr 19, 2024 •
edited
Loading

Description

This PR adds the publisheronly role as a valid option for client token generation.

Motivation and Context

Implements functionality in the SDK which has recently been added to the API.

How Has This Been Tested?

Unit tests added and//or ammended to test the functionality.

Example Output or Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled marked this pull request as ready for review April 19, 2024 15:51
dragonmantank
dragonmantank previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superchilled superchilled merged commit 4b5d7f4 into main Apr 22, 2024
13 checks passed
@superchilled superchilled deleted the add-publisheronly-token-role branch April 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulajet abdulajet abdulajet approved these changes

@dragonmantank dragonmantank dragonmantank left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superchilled @dragonmantank @abdulajet