fix: spells and runes interactions #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oops.
fix conflits.
fix conflits
|
It's not yet possible to throw an avalanche at a magic wall (ID 2128 and 10181). |
Fix murilo09 issue.
Can you test again? |
Now the aggressive flag check is the first condition to be evaluated. If aggressive is false, the function immediately returns RETURNVALUE_NOERROR, bypassing all the other checks that follow.
murilo09
requested changes
Feb 7, 2025
Co-authored-by: murilo09 <[email protected]>
|
I’ll test it tomorrow |
|
murilo09
approved these changes
Feb 9, 2025
This was
linked to
issues
Feb 9, 2025
Closed
majestyotbr
approved these changes
Feb 9, 2025
lucas-caminha
pushed a commit
to lucas-caminha/canary
that referenced
this pull request
Feb 10, 2025
vllworldbuilding
pushed a commit
to vllworldbuilding/canary
that referenced
this pull request
Feb 20, 2025
|
hello @kaleohanopahala I have a problem when you cast a spell on a wall in the south position 0 sqm's away note: only occurred on walls in the south position, spells and runes ignore a 20250223-2302-26.6136320.movwall mechanic and continue after walls i need revert the pr and all issuse are solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe can close issue #2446 and #2794
#Reopened because I accidentally deleted the repository.