You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the imbuement decay system, changing it from a player-wide loop to a per-item approach. This significantly optimizes performance by reducing redundant checks and focusing only on items that require decay updates. The refactor includes:
Dynamic scheduling based on active imbuements.
Handling decay conditions for protection zones, fight mode, and backpack rules directly on individual items.
Improved scalability and maintainability of the code.
The previous implementation iterated through all players and their inventory items to process imbuement decay. This led to unnecessary overhead, even for players with no relevant items.
Expected
The new implementation tracks only items with active imbuements, dynamically managing their decay schedule and conditions. This minimizes unnecessary processing and ensures accurate decay handling.
Type of change
Performance improvement (non-breaking change that improves efficiency)
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested
The changes were tested with the following scenarios:
Test A: Items with imbuements were observed for accurate decay, ensuring decay stops or continues correctly based on conditions.
Test B: Players in protection zones and fight mode were tested to ensure appropriate imbuement handling.
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Refactored the imbuement decay system to manage individual items directly instead of iterating through all players. This improves performance by:
Tracking only items with active imbuements.
Scheduling events dynamically based on items needing updates.
Reducing redundant checks and player-wide loops.
Simplifying imbuement decay logic while preserving existing functionality, including protection zone, fight mode, and backpack-specific rules.
This change optimizes the handling of imbuements and ensures better scalability.
Function stopImbuementDecay need to check if it can decay imbuement duration before doing it, otherwise it will decay the imbuement time when you unequip an item from the inventory, no matter if it can or not decay, based on the elapsed time. For example, it decays when in protection zones.
Function stopImbuementDecay need to check if it can decay imbuement duration before doing it, otherwise it will decay the imbuement time when you unequip an item from the inventory, no matter if it can or not decay, based on the elapsed time. For example, it decays when in protection zones.
I didn't understand your comment. Have you tested it? This check has already been done.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dudantas
force-pushed
the
dudantas/perf-check-imbuements
branch
from
Description
This refactors the imbuement decay system, changing it from a player-wide loop to a per-item approach. This significantly optimizes performance by reducing redundant checks and focusing only on items that require decay updates. The refactor includes:
Resolves #3135
Behaviour
Actual
The previous implementation iterated through all players and their inventory items to process imbuement decay. This led to unnecessary overhead, even for players with no relevant items.
Expected
The new implementation tracks only items with active imbuements, dynamically managing their decay schedule and conditions. This minimizes unnecessary processing and ensures accurate decay handling.
Type of change
How Has This Been Tested
The changes were tested with the following scenarios:
Checklist