Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pr template #988

Open
wants to merge 1 commit into
base: devnet-ready
Choose a base branch
from
Open

Conversation

eagr
Copy link
Contributor

@eagr eagr commented Nov 17, 2024

Description

Hopefully could save everyone a little bit of time writing PRs.

  • remove brackets in closes, it ain't work (less editing)
  • add "housekeeping" item to type of change, which is a huge part of development (less typing)
  • comment out some of the instructional text (less editing)
  • remove screenshot section, PR rarely need a screenshot, and when it does screenshots fit perfectly in the additional info section (less editing, less noise)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): PR template

@eagr eagr requested a review from unconst as a code owner November 17, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant