Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/polkadot sdk v1.16.0 #827

Merged
merged 105 commits into from
Sep 25, 2024
Merged

Feat/polkadot sdk v1.16.0 #827

merged 105 commits into from
Sep 25, 2024

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Sep 20, 2024

Description

Update to Polkadot SDK 1.16.

Details: Biggest changes and testing

  • System-specific RPC methods on full client stopped using DenyUnsafe (before vs. after), but the safety check is still in place and there is a test for that. Tested manually to confirm:
$ curl -H "Content-Type: application/json" -d '{"jsonrpc":"2.0", "method":"system_health", "params":[], "id":1}' http://localhost:9945

Provided Host header is not whitelisted.
$ curl -H "Content-Type: application/json" -d '{"jsonrpc":"2.0", "method":"system_health", "params":[], "id":1}' http://localhost:9945

{"jsonrpc":"2.0","id":1,"result":{"peers":1,"isSyncing":false,"shouldHavePeers":false}}

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): dependency update

Breaking Change

n/a

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

n/a

Additional Notes

n/a

unconst and others added 30 commits August 27, 2024 17:27
Testnet Deployment 27082024
…total_issuance

Revert "hotfix: bumps testnet total issuance"
@gztensor gztensor requested a review from unconst as a code owner September 20, 2024 23:55
@gztensor gztensor marked this pull request as draft September 20, 2024 23:58
@gztensor gztensor marked this pull request as ready for review September 21, 2024 00:11
orriin
orriin previously approved these changes Sep 23, 2024
Comment on lines 145 to 149
spec_version: 196,
spec_version: 202,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the change. This was +1 to Finney version, but we will be updating it to the correct one anyway later.

JohnReedV
JohnReedV previously approved these changes Sep 23, 2024
sam0x17
sam0x17 previously approved these changes Sep 24, 2024
@gztensor gztensor dismissed stale reviews from sam0x17, JohnReedV, and orriin via ce5fdf1 September 24, 2024 16:27
@unconst unconst merged commit d12309b into devnet-ready Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants