Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add move_stake extrinsic and tests #1161

Open
wants to merge 3 commits into
base: devnet-ready
Choose a base branch
from
Open

Re-add move_stake extrinsic and tests #1161

wants to merge 3 commits into from
+921 −22

Conversation

gztensor
Copy link
Contributor

Description

Add move_stake extrinsic and tests.

Related Issue(s)

n/a

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor marked this pull request as ready for review January 15, 2025 21:41
@gztensor gztensor requested a review from unconst as a code owner January 15, 2025 21:41
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 15, 2025
@sam0x17 sam0x17 removed the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 15, 2025
camfairchild
camfairchild approved these changes Jan 15, 2025
View reviewed changes
pallets/subtensor/src/macros/events.rs
@@ -17,6 +17,8 @@ mod events {
StakeAdded(T::AccountId, T::AccountId, u64, u64, u16),
/// stake has been removed from the hotkey staking account onto the coldkey account.
StakeRemoved(T::AccountId, T::AccountId, u64, u64, u16),
/// stake has been moved from origin (hotkey, subnet ID) to destination (hotkey, subnet ID).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// stake has been moved from origin (hotkey, subnet ID) to destination (hotkey, subnet ID).
/// stake has been moved from origin (hotkey, subnet ID) to destination (hotkey, subnet ID) of this amount (in TAO).

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 15, 2025
@camfairchild camfairchild self-requested a review January 15, 2025 21:50
camfairchild
camfairchild requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rate limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild requested changes

@unconst unconst Awaiting requested review from unconst unconst is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gztensor @camfairchild @sam0x17