New script requested_changes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YustinaKvr
commented
Jun 12, 2024
YustinaKvr
commented
- Script requested_changes.py has been added
anton-sidelnikov
approved these changes
Jun 14, 2024
anton-sidelnikov
requested changes
Jun 14, 2024
Comment on lines
+21
to
+50
| db_host = os.getenv("DB_HOST") | ||
| db_port = os.getenv("DB_PORT") | ||
| db_csv = os.getenv("DB_CSV") # main postgres db, where open PRs tables for both public and hybrid clouds are stored | ||
| db_user = os.getenv("DB_USER") | ||
| db_password = os.getenv("DB_PASSWORD") | ||
|
|
||
|
|
||
| def check_env_variables(): | ||
| required_env_vars = [ | ||
| "DB_HOST", "DB_PORT", | ||
| "DB_CSV", "DB_USER", "DB_PASSWORD", "GITEA_TOKEN" | ||
| ] | ||
| for var in required_env_vars: | ||
| if os.getenv(var) is None: | ||
| raise Exception("Missing environment variable: %s", var) | ||
|
|
||
|
|
||
| def connect_to_db(db_name): | ||
| logging.info("Connecting to Postgres (%s)...", db_name) | ||
| try: | ||
| return psycopg2.connect( | ||
| host=db_host, | ||
| port=db_port, | ||
| dbname=db_name, | ||
| user=db_user, | ||
| password=db_password | ||
| ) | ||
| except psycopg2.Error as e: | ||
| logging.error("Connecting to Postgres: an error occurred while trying to connect to the database: %s", e) | ||
| return None |
There was a problem hiding this comment.
i don't understand why are you using same code in all files, please introduce db class and reuse it
There was a problem hiding this comment.
same for env variables
anton-sidelnikov
requested changes
Jun 14, 2024
Comment on lines
+346
to
+348
| org_string = "docs" | ||
| rtc_table = "repo_title_category" | ||
| changes_table = "requested_changes" |
There was a problem hiding this comment.
if using const, better not to store them here, move to first lines and probably good to have ability to change them through env variables
Comment on lines
+360
to
+361
| main(org_string, rtc_table, changes_table) | ||
| main(f"{org_string}-swiss", f"{rtc_table}_swiss", f"{changes_table}_swiss") |
There was a problem hiding this comment.
use for cycle by dictionary with envs, in case that in future there will be more environments and add logging for each call. Also main is a bad name for this func
anton-sidelnikov
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.