Cce scenario #1
Open
Cce scenario #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtema
requested changes
Oct 31, 2019
|
|
||
| if cluster: | ||
| conn.cce.delete_cluster(cluster) | ||
| time.sleep(100) |
| if cluster: | ||
| conn.cce.delete_cluster(cluster) | ||
| time.sleep(100) | ||
|
|
There was a problem hiding this comment.
I will do a complete flake8 check. This was not understood when I created this test case. Now it will be done.
|
|
||
| if cluster and node: | ||
| node = conn.cce.delete_cluster_node(cluster, node) | ||
| time.sleep(90) |
There was a problem hiding this comment.
can't bind node.job_id because the session is lost after delete
playbooks/scenario18_create_cce.yaml
Outdated
| set_fact: | ||
| test_keypair_name: "{{ (prefix + 'keypair') }}" | ||
| vpc_name: "{{ ( prefix + 'router' ) }}" | ||
| nw_name: "{{ ( prefix + 'network' ) }}" |
| script: list_cce_clusters.py | ||
|
|
||
| - name: Create CCE cluster | ||
| script: "create_cce_cluster.py {{ cce_name }} {{ net_router['id'] }} {{ net_network['id'] }}" |
There was a problem hiding this comment.
if you update script to also do router_id = conn.network.find_router(sys.argv[1]) and same for network you can simply pass names
There was a problem hiding this comment.
Not possible, because network names are not unique in Open Telekom Cloud. This could result in more than one network ID which will raise an error.
tischrei
commented
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCE scenario18 finished.
open: wait_for_node function