Fix #792 - Add support for HotWaterEquipment and HotWaterEquipmentDefinition #793
Conversation
jmarrec
commented
Feb 27, 2025
jmarrec
commented
- Fix Add support for HotWaterEquipment and HotWaterEquipmentDefinition #792
| HotWaterEquipmentInspectorView.cpp | ||
| HotWaterEquipmentInspectorView.hpp |
There was a problem hiding this comment.
This is really a copy paste from ElectricEquipment it behaves exactly the same.
| <file>images/mini_icons/hotwater_equipment.png</file> | ||
| <file>images/mini_icons/[email protected]</file> | ||
| <file>images/mini_icons/hotwater_equipment_definition.png</file> | ||
| <file>images/mini_icons/[email protected]</file> |
There was a problem hiding this comment.
Icons registered in qrc
| @@ -146,6 +146,8 @@ TEST_F(OpenStudioLibFixture, IconLibrary_MiniIcon) { | |||
| iddObjectTypes.push_back(IddObjectType::OS_Fan_VariableVolume); | |||
| iddObjectTypes.push_back(IddObjectType::OS_GasEquipment); | |||
| iddObjectTypes.push_back(IddObjectType::OS_GasEquipment_Definition); | |||
| iddObjectTypes.push_back(IddObjectType::OS_HotWaterEquipment); | |||
| iddObjectTypes.push_back(IddObjectType::OS_HotWaterEquipment_Definition); | |||
There was a problem hiding this comment.
test them in case we delete them by mistake
| void LoadsInspectorView::showHotWaterEquipmentDefinitionsInspector(const openstudio::model::ModelObject& modelObject) { | ||
| auto* hotWaterEquipmentDefinitionInspectorView = new HotWaterEquipmentDefinitionInspectorView(m_isIP, m_model); | ||
| connect(this, &LoadsInspectorView::toggleUnitsClicked, hotWaterEquipmentDefinitionInspectorView, | ||
| &HotWaterEquipmentDefinitionInspectorView::toggleUnitsClicked); | ||
|
|
||
| hotWaterEquipmentDefinitionInspectorView->selectModelObject(modelObject); | ||
|
|
||
| showInspector(hotWaterEquipmentDefinitionInspectorView); | ||
| } |
| case IddObjectType::OS_HotWaterEquipment_Definition: | ||
| openstudio::model::HotWaterEquipmentDefinition(this->model()); | ||
| break; |
| label = | ||
| new QLabel("<i>The object models hot water equipment in the zone which consumes district heating, such as cooking equipment or process loads. " | ||
| "All of the energy consumed by the equipment becomes a heat gain in the zone or is lost (exhausted). " | ||
| "This object consumes district heating energy directly and does not cause a load on a hot water plant loop or water heater. " | ||
| "For domestic hot water uses, such as sinks and showers, see WaterUse:Equipment.</i>"); | ||
| label->setWordWrap(true); | ||
| mainGridLayout->addWidget(label, 9, 0, 1, 4); |
There was a problem hiding this comment.
b5e439b is an optional commit.
Add a footnote clarifying what the object is, because I think there's going to be confusion with the Water use Equipment one.
Text is from the I/O reference guide: https://bigladdersoftware.com/epx/docs/24-2/input-output-reference/group-internal-gains-people-lights-other.html#hotwaterequipment
There is no precedent, so I'd like people to weight in on whether this is helpful or not, anbd whether it should be displayed differently in the UI.
Made it look like this
@macumber @marccosta @chrisbalbach @craigers290 @antonszilasi
There was a problem hiding this comment.
Yeah, I was looking at the IDD and I/O Reference trying to figure out why this wasn't added in the first place. It is a bit confusing that it doesn't hook up to a water loop. I think the text is helpful and looks pretty good. If we wanted to be super fancy, we could add a "for more information" link to the I/O Reference. That could be a general pattern but it might be too hard to maintain though.
There was a problem hiding this comment.
It's really the dhw equivalent of the ZoneHVACIdealLoadsAirSystem.
I agree that I don't want to keep external links up to date.
